Skip to content

Preserve first failed Playwright artifacts - #13893

Merged
JordanNoone merged 2 commits into
mainfrom
codex/preserve-first-playwright-artifacts
Sep 18, 2026
Merged

JordanNoone merged 2 commits into
mainfrom
codex/preserve-first-playwright-artifacts

Conversation

@JordanNoone

@JordanNoone JordanNoone commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Preserve the first failed Playwright test-results before --last-failed or full-shard global-error recovery, then restore it under test-results/first-failure for the existing artifact upload. Final retry results and the retry policy remain unchanged.

Fixes #13891.

Validation: bash -n .github/ci-cd-scripts/playwright-electron.sh; node --test scripts/check-playwright-run.test.mjs (7/7 passed).

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modeling-app Ready Ready Preview Sep 18, 2026 2:06pm UTC

Request Review

@JordanNoone

Copy link
Copy Markdown
Contributor Author

Final TAB diagnosis for this head:

  • Actions are green (53 successes plus the expected release skip).
  • GitHub's terminal TAB status says 9449 of 9450 passing, 1 new failure (updated 2026-09-16 06:13:51 UTC).
  • The authenticated status target now returns 0 results with show=fails for the same branch/latest commit.

This is a stale status, not a remaining test failure. TAB publishes release health before its deferred bulk-result pass demotes older retry attempts. I filed KittyCAD/test-analysis-bot#449 after an open/closed duplicate search and drafted KittyCAD/test-analysis-bot#450 with the ordering fix and regression coverage. I did not rerun or change this modeling-app head.

Base automatically changed from codex/retry-playwright-global-errors to main September 16, 2026 14:04
@JordanNoone
JordanNoone force-pushed the codex/preserve-first-playwright-artifacts branch from 0836b7e to 6357a03 Compare September 18, 2026 05:02
@JordanNoone
JordanNoone marked this pull request as ready for review September 18, 2026 05:39
@JordanNoone
JordanNoone requested review from a team as code owners September 18, 2026 05:39
@JordanNoone
JordanNoone enabled auto-merge (squash) September 18, 2026 05:49
@JordanNoone
JordanNoone merged commit d318ae8 into main Sep 18, 2026
56 checks passed
@JordanNoone
JordanNoone deleted the codex/preserve-first-playwright-artifacts branch September 18, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve first failed Playwright artifacts before retry

2 participants