Skip to content

Update dependencies #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/Documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@latest
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: '1'
- name: Install dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ jobs:
arch: x64
allow_failure: true
steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@v1
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: actions/cache@v1
- uses: actions/cache@v4
env:
cache-name: cache-artifacts
with:
Expand Down
10 changes: 5 additions & 5 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7"

[compat]
ADNLPModels = "0.4.0 - 0.8"
ForwardDiff = "0.10"
ForwardDiff = "0.10 - 1"
JuMP = "1"
MathOptInterface = "1"
NLPModelsJuMP = "0.13"
ReverseDiff = "1.14"
Symbolics = "4.10.4 - 5.1"
julia = "^1.6.0"
NLPModelsJuMP = "^0"
ReverseDiff = "1"
Symbolics = "4 - 6"
julia = "1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth being more specific here like 1.10 or lts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to be the more generable possible, such that julia 1.7 and julia 1.11 could pass the tests.
If I am more specific on package requirements, I get conflicts.
I know I can of trust the package manager, but it seems to work.

Just to let you know, I'll update soon my other packages.
Since I may have some tests to run from PartitionedKnetNLPModels, I'll try to keep both julia 1.7 and its latest versions running.
The idea is to ensure PartitionedKnetNLPModels will run on the setup I had at the end of the thesis (Knet didn't update anything since then, so I fear conflicts with more recent package versions).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You actually want to maintain the LTS which is Julia 1.10 and if anything below doesn't work that's fine (we no longer test it).
You can simply write julia = 1.10 and the CI should still be able to run

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously next release is a breaking release.


[extras]
ADNLPModels = "54578032-b7ea-4c30-94aa-7cbd1cce6c9a"
Expand Down
4 changes: 2 additions & 2 deletions docs/Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7"

[compat]
Documenter = "~0.25"
Documenter = "0.25 - 1"
JuMP = "1"
MathOptInterface = "1"
Symbolics = "4.10.4 - 5.1"
Symbolics = "4 - 6"
4 changes: 2 additions & 2 deletions docs/make.jl
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ makedocs(
],
doctest = true,
# linkcheck = true,
strict = true,
# strict = true,
format = Documenter.HTML(
assets = ["assets/style.css"],
prettyurls = get(ENV, "CI", nothing) == "true",
prettyurls = get(ENV, "CI", nothing) == "true"; size_threshold=1000000
),
sitename = "ExpressionTreeForge.jl",
pages = Any["Home" => "index.md", "Tutorial" => "tutorial.md", "Reference" => "reference.md"],
Expand Down
Loading