-
Notifications
You must be signed in to change notification settings - Fork 3
Update dependencies #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bf8ba8d
to
fe070a4
Compare
fe070a4
to
a3f6e1b
Compare
@dpo, I solved my issues with dependencies, except for nightly builds. |
NLPModelsJuMP = "^0" | ||
ReverseDiff = "1" | ||
Symbolics = "4 - 6" | ||
julia = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably worth being more specific here like 1.10
or lts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to be the more generable possible, such that julia 1.7 and julia 1.11 could pass the tests.
If I am more specific on package requirements, I get conflicts.
I know I can of trust the package manager, but it seems to work.
Just to let you know, I'll update soon my other packages.
Since I may have some tests to run from PartitionedKnetNLPModels, I'll try to keep both julia 1.7 and its latest versions running.
The idea is to ensure PartitionedKnetNLPModels will run on the setup I had at the end of the thesis (Knet didn't update anything since then, so I fear conflicts with more recent package versions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You actually want to maintain the LTS which is Julia 1.10 and if anything below doesn't work that's fine (we no longer test it).
You can simply write julia = 1.10
and the CI should still be able to run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously next release is a breaking release.
If it doesn't seem to concern your package directly, you can tolerate the nighlty failing. |
I get an error related to ExpressionTreeForge.jl that doesn't exist for julia 1.7 and 1.11: WARNING: Imported binding M_interface_expr_tree._transform_to_Expr_JuMP was undeclared at import time during import to M_trait_expr_tree.
...
ERROR: LoadError: invalid method definition in M_trait_expr_tree: exported function
M_interface_expr_tree._transform_to_Expr_JuMP does not exist
|
Catch up 1 year or so of dependencies