Skip to content

Run the threaded pencil chunks with Polyester's @batch #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pankgeorg wants to merge 1 commit into
base: integration/all
Choose a base branch
from
Open

Run the threaded pencil chunks with Polyester's @batch #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
MuladdMacro = "46d2c3a1-f734-5fdb-9937-b9b9aeba4221"
Polyester = "f517fe37-dbe3-4b94-8317-1923a5111588"
PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
Primes = "27ebfcd6-29c5-5fa9-bf4b-fb8fc14df3ae"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Expand All @@ -21,6 +22,7 @@ ExplicitImports = "1.12"
FFTW = "1.8"
LinearAlgebra = "<0.0.1, 1"
MuladdMacro = "0.2"
Polyester = "0.7"
PrecompileTools = "1"
Primes = "0.5"
Random = "<0.0.1, 1"
Expand Down
1 change: 1 addition & 0 deletions src/FFTA.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ using AbstractFFTs: AbstractFFTs
using DocStringExtensions: TYPEDEF, TYPEDSIGNATURES
using LinearAlgebra: LinearAlgebra
using MuladdMacro: @muladd
using Polyester: @batch
using Primes: Primes
using Reexport: @reexport

Expand Down
8 changes: 4 additions & 4 deletions src/plan.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,13 +282,13 @@ function _foreach_pencil(f::F, A::AbstractArray{<:Any,N}, ::Val{dim}, workers::V
total = npre * length(Rpost)
nt = min(length(workers), total ÷ 2)
if nt > 1 && total * size(A, dim) >= THREAD_THRESHOLD
Base.@sync for c in 1:nt
# one chunk per worker, run on Polyester's static thread pool (no task
# allocation, the calling thread takes a chunk itself)
@batch for c in 1:nt
lo = (c - 1) * total ÷ nt + 1
hi = c * total ÷ nt
# (the task's worker gets its own name: a variable shared with the
# serial branch below would be captured by every task)
wc = workers[c]
Threads.@spawn for k in lo:hi
for k in lo:hi
ipost, ipre = divrem(k - 1, npre)
f(wc, Rpre[ipre + 1], Rpost[ipost + 1])
end
Expand Down