Run the threaded pencil chunks with Polyester's @batch - #2
Open
pankgeorg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One
@batchchunk per worker instead of oneThreads.@spawntask per chunk in_foreach_pencil(src/plan.jl); output bit-identical, new dependency Polyester.compare3 vs
integration/all@ 901692b, aarch64 Neoverse-N1, 117 N-d/batched cases per thread count: 1 thread 0.99×, 4 threads 1.05×, 16 threads 1.16× geomean (0.95–1.91), no case slower by >5 % — e.g. batched 4096×64 400→216 µs, 1024×64 81→43 µs, 64³ 1.10→0.83 ms, 128³ 11.7→7.9 ms; DRAM-bound 64×65536 at parity. x86-64 (Core Ultra 7 165H, 6P+8E,benchmark/x86-64/compare3/polyester/onbench/x86-compare3): 32K–256K-element band 1.32× at 4 threads, 1.79× at 8, 2.32× at 12 —@spawnsaturates at 8 threads (4.5×),@batchkeeps scaling (6.9× at 12); <32K and DRAM-bound bands at parity, checksums identical. Tables:benchmark/compare3/aarch64/polyester/COMPARE3.mdonbench/compare3.Tested: full suite green on 4 threads.