Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid hack for scitype import #709

Closed
wants to merge 1 commit into from
Closed

avoid hack for scitype import #709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/MLJBase.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ import StatisticalTraits.info

# Interface

# HACK: When https://github.com/JuliaAI/MLJModelInterface.jl/issues/124 and
# https://github.com/JuliaAI/MLJModelInterface.jl/issues/131 is resolved:
# HACK: When https://github.com/JuliaAI/MLJModelInterface.jl/issues/124
# Uncomment next line and delete "Hack Block"
# using MLJModelInterface
#####################
Expand All @@ -37,8 +36,7 @@ for name in exported_names(MLJModelInterface)
name in [
:UnivariateFinite,
:augmented_transform,
:info,
:scitype # Needed to avoid clashing with `ScientificTypes.scitype`
:info
] && continue
quote
import MLJModelInterface.$name
Expand Down