New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid hack for `scitype` import #709

Closed

OkonSamuel wants to merge 1 commit into dev from scitype

Member

OkonSamuel commented Jan 4, 2022 •

edited

Loading

Avoid hack that was previously required to avoid name clashes with scitype method when using both ScientificTypes.jl and MLJModelInterface.jl.

The following steps are required, the first four needed before merging this PR and the last after merging.

Merge don't export scitype method MLJModelInterface.jl#135.
Yank MLJModelInterface (v1.3.4, v1.3.5) and MLJBase v0.19.2
Tag a new patch release (v 1.6.0) for MLJModelInterface.
Re-run tests for this PR and Merge if all tests pass.
Tag a new minor release (v 1.19.3) for MLJBase.


          avoid hack for scitype import

d04a4db

OkonSamuel marked this pull request as draft

January 4, 2022 12:36

ablaom closed this

DilumAluthge deleted the scitype branch

January 23, 2022 20:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet