Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump minimum Node version to 18.12 and TypeScript to 4.8.4 #531

Merged
merged 23 commits into from
Dec 1, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 22, 2024

PR Checklist

Overview

Removes the following methods that rely on deprecated parts of TypeScript:

  • isInputFiles (ts.SyntaxKind.InputFiles)
  • isUnparsedPrologue (ts.SyntaxKind.UnparsedPrologue)
  • isUnparsedSourceText (ts.isUnparsedPrepend, ts.isUnparsedTextLike)
  • isUnparsedSyntheticReference (ts.SyntaxKind. UnparsedSyntheticReference)

Also bumps all devDependencies to latest (ncu -u) to work on the latest Node 22 and 23 in CI.

💖

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat!: bump minimum Node version to 18.12 feat!: bump minimum Node version to 18.12 and TypeScript to 4.8.4 Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 49.65653% with 513 lines in your changes missing coverage. Please review.

Project coverage is 76.26%. Comparing base (30a5818) to head (6683dd7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/nodes/typeGuards/union.ts 9.66% 187 Missing ⚠️
src/usage/UsageWalker.ts 66.22% 77 Missing ⚠️
src/usage/scopes.ts 60.84% 65 Missing ⚠️
src/nodes/access.ts 35.00% 52 Missing ⚠️
src/types/utilities.ts 67.79% 38 Missing ⚠️
src/comments.ts 16.66% 25 Missing ⚠️
src/nodes/utilities.ts 22.22% 21 Missing ⚠️
src/usage/getUsageDomain.ts 70.49% 18 Missing ⚠️
src/usage/declarations.ts 11.11% 8 Missing ⚠️
src/usage/getPropertyName.ts 0.00% 6 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   80.93%   76.26%   -4.67%     
==========================================
  Files          35       50      +15     
  Lines        6666     4946    -1720     
  Branches      448      663     +215     
==========================================
- Hits         5395     3772    -1623     
+ Misses       1271     1173      -98     
- Partials        0        1       +1     
Flag Coverage Δ
4.3.5 ?
4.6.4 ?
4.8.4 73.59% <46.90%> (?)
4.9.5 ?
latest 75.83% <47.59%> (-4.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RebeccaStevens
Copy link
Collaborator

RebeccaStevens commented Nov 13, 2024

@JoshuaKGoldberg I updated a few things. LGTM now

@JoshuaKGoldberg JoshuaKGoldberg removed the status: blocked Waiting for something else to be resolved 🙅 label Nov 14, 2024
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Nov 14, 2024

Great thanks! I think we should wait on #535 to get these merged in the same time, since #535 is a breaking change too.

Edit: #535 was switched to non-breaking; now it's #574 -> #575. Also #573 -> #576.

@JoshuaKGoldberg
Copy link
Owner Author

I'd like to merge this, #575, and #576 all at the same time to get one big breaking change v2. fyi @kirkwaiblinger @RebeccaStevens

@RebeccaStevens RebeccaStevens force-pushed the 2.0.0-beta0 branch 5 times, most recently from 927cd2b to b1d3896 Compare November 25, 2024 06:14
@RebeccaStevens
Copy link
Collaborator

I think all 3 of these PRs are ready now.

@RebeccaStevens
Copy link
Collaborator

RebeccaStevens commented Nov 25, 2024

Note: generated docs will now be pushed directly to the main branch rather than the gh-pages branch (The gh-pages branch can be delete once this is merged). Repo setting will need to be updated to reflect this change.
It might be possible that we don't need to push the generated docs to any branch at all, I'll look into this.

Edit: Docs don't need to be pushed to any branch.

@RebeccaStevens
Copy link
Collaborator

@JoshuaKGoldberg I think this is all good to go now. Do you want to give it one last look over and then push the merge button if it all looks good to you?

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7935007 into main Dec 1, 2024
21 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the 2.0.0-beta0 branch December 1, 2024 02:08
@@ -14,6 +14,7 @@
<!-- prettier-ignore-end -->
<a href="https://github.com/JoshuaKGoldberg/ts-api-utils/blob/main/.github/CODE_OF_CONDUCT.md" target="_blank"><img alt="🤝 Code of Conduct: Kept" src="https://img.shields.io/badge/%F0%9F%A4%9D_code_of_conduct-kept-21bb42" /></a>
<a href="https://codecov.io/gh/JoshuaKGoldberg/ts-api-utils" target="_blank"><img alt="🧪 Coverage" src="https://img.shields.io/codecov/c/github/JoshuaKGoldberg/ts-api-utils?label=%F0%9F%A7%AA%20coverage" /></a>
<a href="#" target="_blank"><img alt="📚 Documentation Coverage" src="https://raw.githubusercontent.com/JoshuaKGoldberg/ts-api-utils/refs/heads/main/docs/coverage.svg" /></a>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh @RebeccaStevens I missed this. #608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants