-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bump minimum Node version to 18.12 and TypeScript to 4.8.4 #531
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
- Coverage 80.93% 76.26% -4.67%
==========================================
Files 35 50 +15
Lines 6666 4946 -1720
Branches 448 663 +215
==========================================
- Hits 5395 3772 -1623
+ Misses 1271 1173 -98
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4f2b6a7
to
a720b0b
Compare
@JoshuaKGoldberg I updated a few things. LGTM now |
0637ca6
to
765e7bf
Compare
I'd like to merge this, #575, and #576 all at the same time to get one big breaking change v2. fyi @kirkwaiblinger @RebeccaStevens |
927cd2b
to
b1d3896
Compare
I think all 3 of these PRs are ready now. |
Edit: Docs don't need to be pushed to any branch. |
b1d3896
to
2280283
Compare
remove extra logic that was need for typedoc-plugin-versions re #580
cb9a5bb
to
aa590f1
Compare
@JoshuaKGoldberg I think this is all good to go now. Do you want to give it one last look over and then push the merge button if it all looks good to you? |
@@ -14,6 +14,7 @@ | |||
<!-- prettier-ignore-end --> | |||
<a href="https://github.com/JoshuaKGoldberg/ts-api-utils/blob/main/.github/CODE_OF_CONDUCT.md" target="_blank"><img alt="🤝 Code of Conduct: Kept" src="https://img.shields.io/badge/%F0%9F%A4%9D_code_of_conduct-kept-21bb42" /></a> | |||
<a href="https://codecov.io/gh/JoshuaKGoldberg/ts-api-utils" target="_blank"><img alt="🧪 Coverage" src="https://img.shields.io/codecov/c/github/JoshuaKGoldberg/ts-api-utils?label=%F0%9F%A7%AA%20coverage" /></a> | |||
<a href="#" target="_blank"><img alt="📚 Documentation Coverage" src="https://raw.githubusercontent.com/JoshuaKGoldberg/ts-api-utils/refs/heads/main/docs/coverage.svg" /></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh @RebeccaStevens I missed this. #608
PR Checklist
status: accepting prs
Overview
Removes the following methods that rely on deprecated parts of TypeScript:
isInputFiles
(ts.SyntaxKind.InputFiles
)isUnparsedPrologue
(ts.SyntaxKind.UnparsedPrologue
)isUnparsedSourceText
(ts.isUnparsedPrepend
,ts.isUnparsedTextLike
)isUnparsedSyntheticReference
(ts.SyntaxKind. UnparsedSyntheticReference
)Also bumps all devDependencies to latest (
ncu -u
) to work on the latest Node 22 and 23 in CI.💖