-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Image save] Change files in filesystem before store to DB #343
[Image save] Change files in filesystem before store to DB #343
Conversation
If a file system problem occurs when moving or renaming a category, the file system may be inconsistent with the database. A proper error message should help fixing the filesystem if needed.
I noticed the following problem during testing: Moving images to another category is not possible if no original image file is available.
|
The filemanager has not taken into account when an imagetype was deactivated in the configs.
Unable to change an image alias. |
I can not reproduce this issue. Changing the alias is perfectly possible. |
It depends on what is set in the JoomGallery configuration for use 'Original filename'.
|
@MrMusic Is fixed now. |
Thanks. I have tested this PR ✅ successfully. |
This PR applies one possible solution to solve the issue reported in #341.
All changes in the file and folders are processed before the item gets stored to the database. If an error appears while changing things in the filesystem, the item will not be stored and the save process is cancelled.
How to test this PR
Create, Edit, Delete, Move, Rename Images and Categories.
Everything should work as before.
Optional: Check that Database and Folderstructure are consistent.