Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with JgTagField #339

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

Elfangor93
Copy link
Member

Before the PR, the Tags-Field in the Image edit form didnt behave correctly. This PR fixes this issues.

  • A JS error is thrown when searching for tags
  • When adding a new tag, the tag was not saved when saving the image

How to test this PR

  • Open the image edit form of an existing Image
  • Open the browser console and observe the console as well as the network tab
  • Search for tags in the tag field
  • Create new tags by hit enter if there are no search results
  • Save image form and check if all tags are correctly listed in the tags field and there are no errors (PHP and JS)

@Elfangor93 Elfangor93 added needs testing This issue or pull request needs further testing GUI testing Tests can be perfomed using the GUI labels Jan 12, 2025
@MrMusic
Copy link
Member

MrMusic commented Jan 16, 2025

I have tested this PR ✅ successfully.
Thank you very much!

@eumel1602
Copy link
Collaborator

eumel1602 commented Jan 17, 2025

Ich habe das Beschriebene erfolgreich getestet... ✅

Was mir aufgefallen ist.:
wenn ich die erstellten Tags der JG (auflistung) verschiedene verschiebungen der reihnefolge mit Drag an drop vornehme, kommt in der konsole ein Fehler:

http://exemplae.de/administrator/index.php?option=com_joomgallery&task=tags.saveOrderAjax&tmpl=component&130f6b89c82d65aa8a6e9515e34110b1=1
Screenshot 2025-01-17 223950

Wenn ich eine allgemine sortierung oben über die Filter optionen vornehme, kommt kein fehler...

@MrMusic
Copy link
Member

MrMusic commented Jan 18, 2025

Was mir aufgefallen ist.:
wenn ich die erstellten Tags der JG (auflistung) verschiedene verschiebungen der reihnefolge mit Drag an drop vornehme, kommt in der konsole ein Fehler:

Der Fehler wird mit PR #334 gefixt.

@Elfangor93 Elfangor93 merged commit dbe2986 into JoomGalleryfriends:main Jan 18, 2025
@eumel1602
Copy link
Collaborator

Ok, entschuldigung! super

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI testing Tests can be perfomed using the GUI needs testing This issue or pull request needs further testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants