Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-empty-sections flag to getChangelog task. #168

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Add --no-empty-sections flag to getChangelog task. #168

merged 5 commits into from
Jun 1, 2023

Conversation

ChrisCarini
Copy link
Contributor

Pull Request Details

Add --no-empty-sections flag to getChangelog task.

Description

Add --no-empty-sections flag to getChangelog task. This flag omits empty sections from the output of getChangelog.

Related Issue

#167

Motivation and Context

See #167 for description and details.

How Has This Been Tested

  • Added unit test
  • Tested locally via local maven release in one of my OSS projects; see output below:
┌─(ChrisCarini)──(2023-04-29 @ 22:50:16)──( ~/GitHub/jetbrains/plugins/sample-intellij-plugin  (main) ) 
└─$ > ./gradlew getChangelog --unreleased --no-header --no-links --no-empty-sections --console=plain -q 
### Changed
- Upgrading IntelliJ from 2023.1 to 2023.1.1

### Deprecated
- Deprecated line


┌─(ChrisCarini)──(2023-04-29 @ 22:50:19)──( ~/GitHub/jetbrains/plugins/sample-intellij-plugin  (main) ) 
└─$ >

...vs...

┌─(ChrisCarini)──(2023-04-29 @ 22:50:19)──( ~/GitHub/jetbrains/plugins/sample-intellij-plugin  (main) ) 
└─$ > ./gradlew getChangelog --unreleased --no-header --no-links --console=plain -q 
### Added

### Changed
- Upgrading IntelliJ from 2023.1 to 2023.1.1

### Deprecated
- Deprecated line

### Removed

### Fixed

### Security


┌─(ChrisCarini)──(2023-04-29 @ 22:50:28)──( ~/GitHub/jetbrains/plugins/sample-intellij-plugin  (main) ) 
└─$ > 

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the README.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ChrisCarini
Copy link
Contributor Author

@YannCebron @hsz - Hello my friends! When you have a few minutes, would you mind taking a look at this PR? Having this feature would help save me some manual work in my release process for several plugins.

@hsz hsz merged commit a94247b into JetBrains:main Jun 1, 2023
@hsz
Copy link
Member

hsz commented Jun 1, 2023

LGTM, thank you!

@hsz hsz added this to the next milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants