Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds on pull requests from forks #170

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

JojOatXGME
Copy link
Contributor

@JojOatXGME JojOatXGME commented May 9, 2023

Pull Request Details

Fixes #169 by fixing the build failures observed in #166 and #168. It might also resolve the build failures of #140 (build logs have expired).

Description

The action dorny/test-reporter@v1 requires write permissions, which are not available for pull requests from forked repositories. This pull request applies the recommended solution as documented on the README.md of the action.

Related Issue

Motivation and Context

Enable the build and merge of external pull requests like #166.

How Has This Been Tested

I created a pull request on my fork with a failing unit test.

JojOatXGME#1

This demonstrates that the test reports are working. However, this test does not demonstrate that the bug is actually fixed, since my pull request is not coming from a different fork.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change) (the content of the “test-reports-*” artifacts have changed)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the README.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The action `dorny/test-reporter@v1` requires write permissions, which
are not available for pull requests from forked repositories.
@JojOatXGME JojOatXGME changed the title Fix builds on forked pull requests Fix builds on pull requests from forks May 10, 2023
@hsz hsz merged commit 5ca56ff into JetBrains:main Jun 1, 2023
@hsz
Copy link
Member

hsz commented Jun 1, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds not working for pull requests from forked repositories
2 participants