✨ web-api: trashed resources include trashedBy with the primary GID of the user that trashed it

[pcrespov]

What do these changes do?

Any resource that was trashed (so far projects, folders or workspace) includes when trashedAt: datetime and who trashedBy: GroupID

• ✨ web-api 0.50.0 → 0.51.0
  • @odeimaiz This is the interface needed for the front-end in 🎨 [Frontend] Show trashedAt and trashedBy on Bin cards #7030
• ♻️ Refactored dependencies between schema and domain models in folders and workspace to fit CSR architecture.
• 🔨 Updated fixtures in api-server

Related issue/s

• part of Feature to undo a delete - "recycle bin" style osparc-issues#468 (trashed_by returns primary GID of user that trashed)
• api for 🎨 [Frontend] Show trashedAt and trashedBy on Bin cards #7030

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_*trash*.py

Dev-ops

None

[codecov]

Codecov Report

Attention: Patch coverage is 82.06107% with 47 lines in your changes missing coverage. Please review.

Project coverage is 87.56%. Comparing base (fb86798) to head (1340862).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7052      +/-   ##
==========================================
+ Coverage   87.16%   87.56%   +0.40%     
==========================================
  Files        1634     1626       -8     
  Lines       64264    63616     -648     
  Branches     2051     2053       +2     
==========================================
- Hits        56013    55706     -307     
+ Misses       7914     7573     -341     
  Partials      337      337              

Flag	Coverage Δ
integrationtests	63.58% <26.41%> (-0.09%)	⬇️
unittests	85.95% <82.06%> (+0.38%)	⬆️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	93.49% <ø> (ø)
pkg_dask_task_models_library	97.09% <ø> (ø)
pkg_models_library	91.31% <84.09%> (-0.12%)	⬇️
pkg_notifications_library	84.57% <ø> (ø)
pkg_postgres_database	88.39% <83.33%> (-0.02%)	⬇️
pkg_service_integration	70.18% <ø> (ø)
pkg_service_library	74.13% <ø> (ø)
pkg_settings_library	90.49% <ø> (ø)
pkg_simcore_sdk	85.38% <ø> (ø)
agent	96.45% <ø> (ø)
api_server	90.55% <ø> (ø)
autoscaling	96.10% <ø> (ø)
catalog	90.32% <ø> (ø)
clusters_keeper	99.24% <ø> (ø)
dask_sidecar	91.26% <ø> (ø)
datcore_adapter	93.18% <ø> (ø)
director	76.92% <ø> (ø)
director_v2	91.25% <ø> (-0.05%)	⬇️
dynamic_scheduler	97.21% <ø> (ø)
dynamic_sidecar	89.75% <ø> (ø)
efs_guardian	90.39% <ø> (ø)
invitations	93.42% <ø> (ø)
osparc_gateway_server	∅ <ø> (∅)
payments	92.66% <ø> (ø)
resource_usage_tracker	89.06% <ø> (-0.12%)	⬇️
storage	89.57% <ø> (ø)
webclient	∅ <ø> (∅)
webserver	85.80% <81.60%> (+1.23%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb86798...1340862. Read the comment docs.

[sanderegg]

thanks! just update the PR description.

[matusdrobuliak66]

Thanks, I have left some comments 👍

[bisgaard-itis]

lgtm
thanks

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud