Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Show trashedAt and trashedBy on Bin cards #7030

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

🎨 [Frontend] Show trashedAt and trashedBy on Bin cards #7030

wants to merge 28 commits into from

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 13, 2025 •
edited
Loading

What do these changes do?

Show trashedAt and trashedBy (for now only available on Workspaces, Folders and Studies coming soon) on Bin cards.

TrashedAtAndBy

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jan 13, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Jan 13, 2025
@odeimaiz odeimaiz self-assigned this Jan 13, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Show trashed at date 🎨 [Frontend] Enh: Show trashedAt date Jan 13, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Show trashedAt date 🎨 [Frontend] Enh: Show trashedAt and trashedBy on Bin items Jan 17, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Show trashedAt and trashedBy on Bin items 🎨 [Frontend] Show trashedAt and trashedBy on Bin items Jan 17, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Show trashedAt and trashedBy on Bin items 🎨 [Frontend] Show trashedAt and trashedBy on Bin cards Jan 17, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 17, 2025 16:25
matusdrobuliak66
matusdrobuliak66 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov pcrespov mentioned this pull request Jan 17, 2025
Open
pcrespov
pcrespov approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the api is also ready!

sanderegg
sanderegg reviewed Jan 19, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@GitHK GitHK Awaiting requested review from GitHK

At least 2 approving reviews are required to merge this pull request.

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @pcrespov @sanderegg @matusdrobuliak66