-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement bigint support #728
Open
glevco
wants to merge
3
commits into
master
Choose a base branch
from
feat/bigint-functions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
feat/bigint-functions
branch
3 times, most recently
from
August 1, 2024 16:46
acb3f0f
to
badafe5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/typing-improvements #728 +/- ##
=================================================================
+ Coverage 66.52% 80.56% +14.04%
=================================================================
Files 78 82 +4
Lines 6156 6209 +53
Branches 1337 1353 +16
=================================================================
+ Hits 4095 5002 +907
+ Misses 1985 1195 -790
+ Partials 76 12 -64 ☔ View full report in Codecov by Sentry. |
glevco
commented
Aug 1, 2024
glevco
force-pushed
the
feat/bigint-functions
branch
from
August 2, 2024 16:46
badafe5
to
fde977c
Compare
glevco
force-pushed
the
refactor/typing-improvements
branch
from
August 2, 2024 20:27
efe15e4
to
c744d46
Compare
glevco
force-pushed
the
feat/bigint-functions
branch
from
August 2, 2024 20:29
fde977c
to
6f9fa0c
Compare
glevco
force-pushed
the
refactor/typing-improvements
branch
from
August 2, 2024 20:45
c744d46
to
1b31680
Compare
glevco
force-pushed
the
feat/bigint-functions
branch
from
August 2, 2024 20:45
6f9fa0c
to
6c44af7
Compare
1 task
glevco
force-pushed
the
refactor/typing-improvements
branch
from
August 2, 2024 21:40
1b31680
to
8cecc72
Compare
glevco
force-pushed
the
feat/bigint-functions
branch
from
August 2, 2024 21:42
6c44af7
to
8ddab19
Compare
glevco
force-pushed
the
refactor/typing-improvements
branch
from
August 13, 2024 21:11
8cecc72
to
59e0572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #720
Motivation
See https://github.com/HathorNetwork/internal-issues/issues/363.
This PR adds the necessary structures to support bigint fields, however it does not yet change the
OutputValueType
tobigint
.Acceptance Criteria
bigIntToBytes()
and removesignedIntToBytes()
support for 8 bytes.unpackToBigInt()
and removeunpackToInt()
support for 8 bytes.bytesToOutputValue()
to useunpackToBigInt()
.json-bigint
andzod
.level-transcoder
was added explicitly but was already an indirect dependency.long
.api/txApi
andapi/wallet
Zod schemas, updating requests to usetransformJsonBigIntResponse()
.Output.valueToBytes()
to usebigIntToBytes()
instead ofsignedIntToBytes()
.jsonBigIntEncoding()
where necessary.utils/bigint.ts
.JSONBigInt.parse()
instead ofJSON.parse()
.es2020
instead ofes2018
, adding support forbigint
.Security Checklist