-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for maximum output values #708
base: feat/bigint-functions
Are you sure you want to change the base?
Conversation
1cd72aa
to
783d11b
Compare
0a73d53
to
086a85f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/bigint-functions #708 +/- ##
========================================================
Coverage ? 54.29%
========================================================
Files ? 82
Lines ? 6209
Branches ? 1343
========================================================
Hits ? 3371
Misses ? 2830
Partials ? 8 ☔ View full report in Codecov by Sentry. |
57e0347
to
f7e6797
Compare
f7e6797
to
ed34f56
Compare
ed34f56
to
2c3c343
Compare
efe15e4
to
c744d46
Compare
3d6628d
to
661b941
Compare
c744d46
to
1b31680
Compare
11e2178
to
a6dda14
Compare
@@ -5,7 +5,7 @@ on: | |||
- release | |||
- release-candidate | |||
- master | |||
- refactor/typing-improvements # TODO: REMOVE THIS | |||
- feat/bigint-functions # TODO: REMOVE THIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this
@@ -12,7 +12,7 @@ on: | |||
- release | |||
- release-candidate | |||
- master | |||
- refactor/typing-improvements # TODO: REMOVE THIS | |||
- feat/bigint-functions # TODO: REMOVE THIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this
6c44af7
to
8ddab19
Compare
a6dda14
to
e541502
Compare
Depends on #728
Motivation
See https://github.com/HathorNetwork/internal-issues/issues/363.
This is the last PR in the
bigint
refactor, and it changes theOutputValueType
tobigint
. It leverages the structures implemented in previous PRs to support this change.Acceptance Criteria
OutputValueType
fromnumber
tobigint
.123
->123n
). This is the bulk of this PR as tests have a lot of literals.-
instead ofMath.abs
as theMath
module does not supportbigint
.Security Checklist