Power-Panic Service #1657
Open
Power-Panic Service #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add rodio to toplevel toml implement first iteration of dbus communiton (get battery) add loop in main function move power-panic from tools/ to services/ adapt Cargo.toml to new project structure add crosscompilation flag to Cargo.toml fix errorhandling
oleflb
requested changes
Mar 2, 2025
reorder imports refactor if statement use imports instead of qualifiers remove one unnecessary println!
oleflb
requested changes
Mar 12, 2025
| let battery = get_battery_info().await?; | ||
| println!("Battery: {:?}", battery); | ||
|
|
||
| let mut time_to_sleep = 60; |
There was a problem hiding this comment.
Please try to use sophisticated types, in this case Duration for representing time. When coding your time as an integer, it is not clear whether you mean seconds, minutes, etc. . You can read more about it here: https://refactoring.guru/smells/primitive-obsession
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
Implementation of an service, that provides auditive Feedback when the battery of the NAO runs out.
ToDo / Known Issues
The service still needs to be added to the meta-nao repository so that it becomes part of the image.
You may can argue about the time-interval of the sound. Right now it is played every charge in % in seconds.
Ideas for Next Iterations (Not This PR)
In the next iteration you think of a possibility to mute the alarm.
How to Test
After creating the binary of the service with
./pepsi build power-panicyou will find the binary in
~/worktree/hulk/services/power-panic/target/debug.Copy the binary to a NAO e. g. using
rsync power-panic [email protected]:~/hulk/bin/and execute it by connecting to the robot e. g. with
./pepsi shell x