geometry::Arc: use angles for start and end
#1609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmburg
added
the
is:Refactoring
knoellle
reviewed
Feb 1, 2025
| @@ -78,14 +78,14 @@ impl<Frame> LineSegment<Frame> { | |||
| self.signed_acute_angle_to_orthogonal(other).abs() < epsilon | |||
| } | |||
|
|
|||
| pub fn projection_factor(&self, point: Point2<Frame>) -> f32 { | |||
| pub fn projection_factor(&self, point: &Point2<Frame>) -> f32 { | |||
There was a problem hiding this comment.
To save a copy here. filter only gives me a reference.
hulk/crates/geometry/src/line_segment.rs
Lines 164 to 166 in f595b94
There was a problem hiding this comment.
Those two floats are probably in a register already or the function may be optimized away completely.
I think we copy our linear algebra types almost everywhere.
"Optimizations" at this level are irrelevent I think
There was a problem hiding this comment.
I completely agree, this was not meant as an optimization, but more of an ergonomics thing. I could just as well create an explicit copy in filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
What the title says. Previously, we used
Point2s for the start and end points of arcs.This made arcs over-defined. A neat side effect of this change is reduced complexity of most of the affected calculations.
ToDo / Known Issues
It's perfect
Ideas for Next Iterations (Not This PR)
It's perfect
How to Test
Stare at the code.
I can add more unit tests if there are any areas where you are unsure if the changes are correct.