Horizontal segments #1201
Merged
Horizontal segments #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schluis
added
the
is:Dependent
rmburg
force-pushed
the
horizontal-segments
branch
from
bfb801a to
cc3216b
Compare
h3ndrk
force-pushed
the
horizontal-segments
branch
4 times, most recently
from
9137726 to
c5f9335
Compare
auto-merge was automatically disabled
July 16, 2024 10:49
Pull request was converted to draft
rmburg
force-pushed
the
horizontal-segments
branch
from
765e4df to
c5f9335
Compare
Co-authored-by: Hendrik <[email protected]>
rmburg
force-pushed
the
horizontal-segments
branch
2 times, most recently
from
77a1881 to
68ffeaa
Compare
rmburg
removed
the
is:Dependent
oleflb
previously requested changes
Jul 17, 2024
schluis
reviewed
Jul 17, 2024
rmburg
force-pushed
the
horizontal-segments
branch
from
6c03d30 to
979eabc
Compare
schluis
approved these changes
Jul 17, 2024
oleflb
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Reimplement horizontal image segments Co-authored-by: Hendrik <[email protected]> * Filter horizontal segments * Fix segmentation tests * Fix review findings * Fix zero length segments --------- Co-authored-by: Hendrik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
What the title says.
Also extends the segmenter panel to show horizontal segments.
Based on #1179.
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test
Use the new "Direction" toggle in the image segmenter twix panel