Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate content to Dutch #1750

Open
tunetheweb opened this issue Dec 11, 2020 · 42 comments
Open

Translate content to Dutch #1750

tunetheweb opened this issue Dec 11, 2020 · 42 comments
Assignees
Labels
good first issue Good for newcomers translation world wide web

Comments

@tunetheweb
Copy link
Member

tunetheweb commented Dec 11, 2020

These are the core templates - without which we cannot release any translated chapters. They are in the language specific templates directory:

  • base.html - @noah-vdv
  • base_chapter.html- @noah-vdv
  • error.html- @noah-vdv

2024

  • base.html -
  • base.html - foreword
  • contributors.html -
  • index.html -
  • table_of_contents.html -

2022

  • base.html -
  • contributors.html -
  • index.html -
  • table_of_contents.html -

2021

  • base.html -
  • base.html - foreword
  • contributors.html -
  • index.html -
  • table_of_contents.html -

2020

  • base.html - @noah-vdv
  • contributors.html - @noah-vdv
  • index.html - @noah-vdv
  • table_of_contents.html - @noah-vdv

2019

  • base.html - @noah-vdv
  • contributors.html - @noah-vdv
  • index.html - @noah-vdv
  • table_of_contents.html - @noah-vdv

These are the chapters to be translated. They exist in the content directory:

2024

  • css -
  • javascript -
  • markup -
  • structured-data -
  • fonts -
  • media -
  • webassembly -
  • third-parties -
  • seo -
  • accessibility -
  • performance -
  • privacy -
  • security -
  • cms -
  • ecommerce -
  • jamstack -
  • sustainability -
  • page-weight -
  • cdn -
  • http -
  • cookies -

2022

  • css -
  • javascript -
  • markup -
  • structured-data -
  • fonts -
  • media -
  • webassembly -
  • third-parties -
  • interoperability -
  • seo -
  • accessibility -
  • performance -
  • privacy -
  • security -
  • mobile-web -
  • capabilities -
  • pwa -
  • cms -
  • jamstack -
  • sustainability -
  • page-weight -
  • cdn -
  • http -

2021

  • css -
  • javascript -
  • markup -
  • structured-data -
  • media -
  • webassembly -
  • third-parties -
  • seo -
  • accessibility -
  • performance -
  • privacy - @VictorLeP
  • security -
  • mobile-web -
  • capabilities -
  • pwa -
  • cms -
  • ecommerce -
  • jamstack -
  • page-weight -
  • compression -
  • caching -
  • cdn -
  • resource-hints -
  • http -

2020

  • css -
  • javascript - @noah-vdv
  • seo - @noah-vdv
  • markup - @noah-vdv
  • accessibility - @noah-vdv
  • cms - @noah-vdv
  • performance - @noah-vdv
  • security - @noah-vdv
  • jamstack - @noah-vdv
  • fonts - @noah-vdv
  • mobile-web - @noah-vdv
  • pwa - @noah-vdv
  • http2 - @noah-vdv
  • capabilities - @noah-vdv
  • third-parties - @noah-vdv
  • page-weight - @noah-vdv
  • caching - @noah-vdv
  • resource-hints - @noah-vdv
  • privacy - @noah-vdv
  • compression - @noah-vdv
  • ecommerce - @noah-vdv
  • media - @noah-vdv

2019

  • javascript -
  • css -
  • seo -
  • performance -
  • http2 -
  • markup -
  • third-parties -
  • fonts -
  • accessibility - @noah-vdv
  • pwa -
  • cms -
  • security -
  • media -
  • mobile-web -
  • cdn -
  • ecommerce -
  • page-weight -
  • caching -
  • compression -
  • resource-hints -

Additionally the following pages need translated too in the language specific templates directory:

There is no need to translate the chapters HTML pages as they are generated off the markdown combined with the above templates.

Please include "Makes progress on #1750" in all pull requests so a link is created from the PR to this issue.


Common notes for writing consistency are here: https://github.com/HTTPArchive/almanac.httparchive.org/wiki/Translators'-Guide. Feel free to edit that and/or add Dutch-specific extras by editing this comment.

Dutch specific extra advice:

@strangernr7
Copy link
Contributor

So the html files don't need to be translated right? Just the files under 2020, 2019 and additional files?

@tunetheweb
Copy link
Member Author

tunetheweb commented Dec 11, 2020

The core html files DO need to be translated.

The chapter HTMLs not shown above (e.g. performance.html) do not need to be translated as they are generated from the markdown (e.g. performance.md). We used to store these generated chapter HTML files in git, but no longer do so probably can remove the statement related to that as probably more confusing than useful. Then again if you run the site locally (see instructions in src/README.md) then it will generate these files but they can be ignored from translation point of view.

That make sense, or have a just confused you more than helped? 😀

@strangernr7
Copy link
Contributor

alright, nah that helped thanks

@rviscomi
Copy link
Member

@noah-vdv thanks for your help translating this content! I see the base templates have been checked off. Have those translations been submitted yet?

@strangernr7
Copy link
Contributor

@noah-vdv thanks for your help translating this content! I see the base templates have been checked off. Have those translations been submitted yet?

No problem.
I have checked them off indeed but realized that I might have translated bits that didn't need translating and totally forgot to check if some pieces needed the <lang="en"> tags. So I'll double-check those html files and get a PR out on Thursday hopefully.

@tunetheweb
Copy link
Member Author

tunetheweb commented Dec 15, 2020

Feel free to open a draft PR for now and I can give feedback.

To @rviscomi ’s point we normally put your name beside something you’re working on (so others don’t work on it too) but only tick it off after PR is accepted to show its “done”. I’ve updated the first comment to that now.

@tunetheweb
Copy link
Member Author

BTW since you've done the base templates we're ready to send this language live so (at the risk of making this PR even bigger!) can you add Dutch to server/language.py (lines 45-54) and also add nl to supported_languages in config/2019.json and config/2029.json?

@strangernr7
Copy link
Contributor

Should I translate content such as First Input Delay or keep it as is?

@tunetheweb
Copy link
Member Author

Should I translate content such as First Input Delay or keep it as is?

I would say not as it's a technical term. Not quite code, but close enough. Maybe add the Dutch translation after first time it's used.

@strangernr7
Copy link
Contributor

What has changed in the 2020 base.html file for it to be translated?

@tunetheweb
Copy link
Member Author

Oh. Looks like you already got the foreword. Most languages didn't. Will remove that one!

Did you see there were some changes to Markup chapter?

@strangernr7
Copy link
Contributor

Oh. Looks like you already got the foreword. Most languages didn't. Will remove that one!

Did you see there were some changes to Markup chapter?

Alright, yeah I'll get to those before I do the seo chapter

@strangernr7
Copy link
Contributor

I was going through the 2020 seo chapter and realized there's still 3 TODO's for authors at around line 500

@strangernr7
Copy link
Contributor

And in some other chapters as well so I'll just do those later

@tunetheweb
Copy link
Member Author

tunetheweb commented Jan 21, 2021

I was going through the 2020 seo chapter and realized there's still 3 TODO's for authors at around line 500

Good spot. I've reviewed them and happy to just remove them. I count 4 though not three (though one is not marked as a TODO but a Note):

{# TODO(authors): Why are the growth of bandwidth and ubiquity of smartphones contributors to image heaviness? #}

Seems pretty obvious to me so don't think it needs further comment. Maybe it was added since that comment was added.

{# TODO(authors): Add your interpretation of these results. What do you hope readers get from it? #}

Yeah would have been nice to have some interpretation rather than just the stats, but not only chapter to do this, so let's leave for now and remove the TODO.

{# TODO(authors, analysts): I don't think the interpretation of these stats was correct, so I edited out anything that I didn't think was accurate. Please double check my edit and feel free to expand on it. Note that this is incompatible with last year's stat because that was a Lighthouse audit checking that all images have alt attributes, while this data was calculated directly from the markup. There's something off if 40+% of pages have perfect alt coverage, but this chart has less than perfect coverage at the 75th percentile. Either coverage got much _worse_ this year or they're measuring different things. For example Lighthouse may be more lenient about which images should have alt attributes. Do you have those audit results based on 2020 data here for better comparison? #}

Rick edited this and I trust his understanding of Lighthouse so to me this is just a comment for Authors during review so TODO can be removed.

{# NOTE(authors): I've made some ruthless edits to this section to remove everything related to synthetic measurement of CWV, including the entire Lighthouse discussion, which is orthogonal to the real-user aspect of CWV. Please push back if you disagree with any of these edits. #}

Same as above so TODO can be removed.

Would you mind removing them from English version too as part of this PR?

And in some other chapters as well so I'll just do those later

I'll try to review those similarly and submit a PR for them. I see Compression, JavaScript, Privacy (currently under re-review anyway), Resource-Hints (this TODO can be removed), Security (not edited yet anyway), and SEO (discussed above). Hold off translating them for now but SEO and Resource Hints can be done.

@strangernr7
Copy link
Contributor

strangernr7 commented Mar 14, 2021

Just a heads up: the 2020 ecommerce chapter has #jrharalson_bio: TODO above the Intro
And I'm pretty sure featured_stat_label_1: Mobile sizes identified as ecommerce sites should be Mobile sites

@tunetheweb
Copy link
Member Author

Yeah we never got a bio from @jrharalson - Jason if you see this and wanna provide one then please do. It appears at the bottom of the chapter.

Agree on the featured stat correction.

@strangernr7
Copy link
Contributor

strangernr7 commented Apr 4, 2021

*Caching entity*: The hardware or software that is doing the caching. Due to the focus of this chapter, we use "browser" as a synonym for "caching entity" unless otherwise specified.

Should Caching entity stay as is or be translated? As well as anywhere else in the chapter

@tunetheweb
Copy link
Member Author

I would translate it. It's not a technical term as such. Same for Eviction and Revalidation further down that list. On the other hand, Time to Live (TTL) is a well-known technical term so I wouldn't translate that,

@strangernr7
Copy link
Contributor

While we see a slight increase in the use of the `Cache-Control` header (1.8%), we also see a minimal decrease in the use of the older `Expires` header (0.2%). On Desktop we actually see a marginal increase of `Cache-Control` (1.3%), with a smaller increase on `Expiries` (0.8%) Effectively, more desktop sites look to be adding `Cache-Control` header without the `Expires` header.

Also, I noticed Expiries instead of Expires, that's a typo right?

@tunetheweb
Copy link
Member Author

Yup! Good spot. If you could fix as part of your translation pull request that would be much appreciated!

@rviscomi
Copy link
Member

Wow only 3 chapters to go! Thank you @noah-vdv for your amazing effort!!

@tunetheweb
Copy link
Member Author

Hey @noah-vdv any chance we could persuade you back to finish off the final to chapters for 2020? Once we have those we can publish the ebook in Dutch! And we’ll even print a copy as a small token of our appreciation you for your efforts!

@strangernr7
Copy link
Contributor

Hey @noah-vdv any chance we could persuade you back to finish off the final to chapters for 2020?

Hey, wow time has flown! Didn't realise how long ago I had last worked on this. Anyways, yeah of course! However, I don't have as much spare time as before but I'll try my best to get it done, hopefully, by November.

Once we have those we can publish the ebook in Dutch! And we’ll even print a copy as a small token of our appreciation you for your efforts!

Awesome!! Looking forward to finishing it off! 👍

@tunetheweb
Copy link
Member Author

tunetheweb commented Nov 17, 2021

We added a small note to our Accessibility Statement about colour contrast issues:

{# TODO - Translate this <p>
In some chapters, we also include other content on the site, not created by ourselves, including YouTube videos, PDF links or links to other articles, which do not meet the strict criteria required of WCAG 2.1 level AAA. See note below on external content.
</p> #}

Would be great if someone could translate this (@noah-vdv ?). Very small and easy!

@strangernr7
Copy link
Contributor

"In sommige hoofdstukken nemen we ook andere inhoud op de site op, die niet door onszelf is gemaakt, waaronder YouTube-video's, pdf-links of links naar andere artikelen, die niet voldoen aan de strikte criteria die vereist zijn voor WCAG 2.1 level AAA. Zie onderstaande opmerking over externe inhoud."

Hey, wow time has flown! Didn't realise how long ago I had last worked on this. Anyways, yeah of course! However, I don't have as much spare time as before but I'll try my best to get it done, hopefully, by November.

Also, i hate to disappoint, but this is taking more time as I need to spend more time on my study than expected. I, unfortunately can't give you an eta yet.

@tunetheweb
Copy link
Member Author

No probs. Thanks for that translation.

@tunetheweb
Copy link
Member Author

Doh! Looks like I gave you the wrong bit of text to translate above :-( That was the next paragraph that was already translated. This was the paragraph I actually wanted translated:

We recognize that some of the color choices for our visualizations do not meet WCAG color contrast requirements. We make a conscious effort to use the more contrasting colors and labels to reduce the impact of this. We hope the detailed descriptions, as well as access to the underlying data itself can help with this issue. We aim to improve the accessibility of our visualization color schemes in future years.

@VictorLeP
Copy link
Contributor

We erkennen dat sommige keuzes voor kleuren in onze visualisaties niet voldoen aan de kleurcontrastvereisten van de WCAG. We doen een bewuste inspanning om de meer contrasterende kleuren en opschriften te gebruiken om de impact hiervan te verminderen. We hopen dat de gedetailleerde beschrijvingen alsook toegang tot de onderliggende gegevens zelf kunnen helpen met dit probleem. We streven ernaar de toegankelijkheid van de kleurschema's in onze visualisaties de komende jaren te verbeteren.

@tunetheweb
Copy link
Member Author

Bedankt @VictorLeP ! Zeer gewaardeerd.

@VictorLeP
Copy link
Contributor

Will also take a stab at translating this year's Privacy chapter (since @noah-vdv is busy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers translation world wide web
Projects
None yet
Development

No branches or pull requests

4 participants