Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translated Javascript 2020 dutch #1803

Merged
merged 7 commits into from
Dec 19, 2020
Merged

translated Javascript 2020 dutch #1803

merged 7 commits into from
Dec 19, 2020

Conversation

strangernr7
Copy link
Contributor

Makes progress on #1750

@strangernr7 strangernr7 added the translation world wide web label Dec 18, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a few things like this:

caption="Verdeling van niet-verkleinde JavaScript Lighthouse-auditscores per mobiele pagina."

You can't nest quotes like this so need to change outer quotes to single quotes.

However, we do say don't bother putting quotes around brand names or technical terms and I think we can include Lighthouse and frameworks in that category, so just went ahead and removed a lot fo these spans. I would just use the lang="en" thing for an English phrase. Should make it easier on you as well.

src/content/nl/2020/javascript.md Outdated Show resolved Hide resolved
@tunetheweb tunetheweb added this to the 2020 Content Translation milestone Dec 19, 2020
@tunetheweb tunetheweb merged commit 646600c into HTTPArchive:main Dec 19, 2020
@strangernr7 strangernr7 deleted the javascript-2020-Dutch branch December 19, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants