Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO's from nl 2020 markup #1905

Merged
merged 5 commits into from
Jan 19, 2021
Merged

Remove TODO's from nl 2020 markup #1905

merged 5 commits into from
Jan 19, 2021

Conversation

strangernr7
Copy link
Contributor

Makes progress on #1750

@strangernr7 strangernr7 added the translation world wide web label Jan 19, 2021
@strangernr7 strangernr7 added this to the 2020 Content Translation milestone Jan 19, 2021
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change to fix the build.

Also did you see the changes in https://github.com/HTTPArchive/almanac.httparchive.org/pull/1858/files?

src/content/nl/2020/markup.md Outdated Show resolved Hide resolved
@strangernr7
Copy link
Contributor Author

One change to fix the build.

Also did you see the changes in https://github.com/HTTPArchive/almanac.httparchive.org/pull/1858/files?

Ah yes I'll add those

@strangernr7
Copy link
Contributor Author

It also needs " after "script element" right?

@tunetheweb tunetheweb merged commit cce7e08 into HTTPArchive:main Jan 19, 2021
@tunetheweb
Copy link
Member

Thank you! Hopefully other chapters won’t have as many changes after translations!

@strangernr7 strangernr7 deleted the Markup-2020-nl branch January 19, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants