Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDAF: change dim_obs_p to dim_obs in add_obs_error_pdaf (LEnKF) #246

Merged
merged 3 commits into from
Nov 6, 2024
Merged

PDAF: change dim_obs_p to dim_obs in add_obs_error_pdaf (LEnKF) #246

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d2e768
PDAF: use PE-local obserr arrays in `add_obs_error_pdaf` (LEnKF)
jjokella Nov 5, 2024
dae8ed2
Revert "PDAF: use PE-local obserr arrays in `add_obs_error_pdaf` (LEn…
jjokella Nov 6, 2024
af66c83
rename `dim_obs_p` to `dim_obs` in `add_obs_error_pdaf`
jjokella Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bldsva/intf_DA/pdaf/framework/add_obs_error_pdaf.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
! !ROUTINE: add_obs_error_pdaf --- Add observation error covariance matrix
!
! !INTERFACE:
SUBROUTINE add_obs_error_pdaf(step, dim_obs_p, C_p)
SUBROUTINE add_obs_error_pdaf(step, dim_obs, C_p)

! !DESCRIPTION:
! User-supplied routine for PDAF.
Expand Down Expand Up @@ -60,8 +60,8 @@ SUBROUTINE add_obs_error_pdaf(step, dim_obs_p, C_p)

! !ARGUMENTS:
INTEGER, INTENT(in) :: step ! Current time step
INTEGER, INTENT(in) :: dim_obs_p ! Dimension of observation vector
REAL, INTENT(inout) :: C_p(dim_obs_p,dim_obs_p) ! Matrix to that
INTEGER, INTENT(in) :: dim_obs ! Dimension of observation vector
REAL, INTENT(inout) :: C_p(dim_obs,dim_obs) ! Matrix to that
! observation covariance R is added

! !CALLING SEQUENCE:
Expand Down Expand Up @@ -90,7 +90,7 @@ SUBROUTINE add_obs_error_pdaf(step, dim_obs_p, C_p)
! *************************************

if(multierr.ne.1) then
DO i = 1, dim_obs_p
DO i = 1, dim_obs
C_p(i, i) = C_p(i, i) + variance_obs
ENDDO
endif
Expand All @@ -104,7 +104,7 @@ SUBROUTINE add_obs_error_pdaf(step, dim_obs_p, C_p)
call abort_parallel()
end if

do i=1,dim_obs_p
do i=1,dim_obs
#if defined CLMSA
C_p(i,i) = C_p(i,i) + clm_obserr(obs_nc2pdaf(i))*clm_obserr(obs_nc2pdaf(i))
#else
Expand Down
Loading