Repository navigation
PDAF: change dim_obs_p to dim_obs in add_obs_error_pdaf (LEnKF) - #246
Merged
Merged
Conversation
Before, `clm_obserr(obs_nc2pdaf(i))` was used, where `i` is looped over `1, dim_obs_p`. However, `obs_nc2pdaf` will then for each PE access the first dimensions from the first PE (or more depending on `dim_obs_p`). The local versions `clm_obserr_p` and `pressure_obserr_p` should contain the correct observation errors.
jjokella
marked this pull request as draft
November 5, 2024 15:56
…KF)" This reverts commit 9d2e768.
This is the dimension of the full observation vector.
jjokella
changed the title
add_obs_error_pdaf (LEnKF)dim_obs_p to dim_obs in add_obs_error_pdaf (LEnKF)
jjokella
marked this pull request as ready for review
November 6, 2024 06:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Former
dim_obs_pinadd_obs_error_pdafwas actually the size of the full observation vector and is therefore better calleddim_obs.The suffix
_pis used in TSMP-PDAF for PE-local variables.