Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #2635 ] Update banner #2972

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Issue #2635 ] Update banner #2972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d054efa
Update index.ts for banner update
acouch Nov 21, 2024
c638cf1
Update BetaAlert.tsx
acouch Nov 21, 2024
1fcf9b7
Update process.spec.ts
acouch Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/components/BetaAlert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import FullWidthAlert from "./FullWidthAlert";

const BetaAlert = () => {
const t = useTranslations("Beta_alert");
const heading = t.rich("alert_title", {
const alert = t.rich("alert", {
LinkToGrants: (content) => <a href="https://www.grants.gov">{content}</a>,
});

Expand All @@ -13,8 +13,8 @@ const BetaAlert = () => {
data-testid="beta-alert"
className="desktop:position-sticky top-0 z-200"
>
<FullWidthAlert type="info" heading={heading}>
{t("alert")}
<FullWidthAlert type="info" heading={t("alert_title")}>
{alert}
</FullWidthAlert>
</div>
);
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/i18n/messages/en/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
export const messages = {
Beta_alert: {
alert_title:
"Attention! Go to <LinkToGrants>www.grants.gov</LinkToGrants> to search and apply for grants.",
"This site is a work in progress, with new features and updates based on your feedback.",
alert:
"Simpler.Grants.gov is a work in progress. Thank you for your patience as we build this new website.",
"Search for grants here. To use more advanced features or to apply, go to <LinkToGrants>www.Grants.gov</LinkToGrants>.",
},
OpportunityListing: {
page_title: "Opportunity Listing",
Expand Down
2 changes: 1 addition & 1 deletion frontend/tests/e2e/process.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test("can view banner and return to top after scrolling to the bottom", async ({

await expect(
page.getByRole("heading", {
name: /Attention! Go to www.grants.gov to search and apply for grants./i,
name: /This site is a work in progress, with new features and updates based on your feedback./i,
}),
).toBeVisible();

Expand Down