Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2635 ] Update banner #2972

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

acouch
Copy link
Collaborator

@acouch acouch commented Nov 21, 2024

Summary

Fixes #2635

Time to review: 5 mins

Changes proposed

New language in banner:

image

image

image

andycochran
andycochran previously approved these changes Nov 21, 2024
doug-s-nava
doug-s-nava previously approved these changes Nov 21, 2024
Copy link
Collaborator

@doug-s-nava doug-s-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is missing some updates to e2e tests but otherwise seems fine. Line spacing on mobile seems a little cramped but that's definitely out of scope

@acouch acouch dismissed stale reviews from doug-s-nava and andycochran via 1fcf9b7 November 22, 2024 15:22
Copy link
Contributor

@emilycnava emilycnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement post Search launch beta alert content
4 participants