Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new command gtctl connect pg #119

Merged
merged 15 commits into from
Aug 9, 2023
Merged

feat: add new command gtctl connect pg #119

merged 15 commits into from
Aug 9, 2023

Conversation

sjcsjc123
Copy link
Contributor

image

sjcsjc123 and others added 15 commits June 16, 2023 00:33
@sjcsjc123
fix bug with upload etcd file fail in the case of OS:linux and `Arc…
cfe4b9a 
…h:amd64`
@sjcsjc123
fix bug with upload etcd file fail in the case of OS:linux and `Arc…
5a418a3 
…h:amd64`
@sjcsjc123
run golanglint has make error: `TrimSuffix doesn't have side effect…
5f0dce9 
…s and its return value is ignored`
@sjcsjc123
determine ext by GOOS
b50c5e1
@sjcsjc123
Merge branch 'GreptimeTeam:develop' into develop
ef96ad7
@sjcsjc123
modify const and code style
d999428
@sjcsjc123
add gtctl connect mysql://user:password@host:port command
1dfc06f
@sjcsjc123
Merge branch 'GreptimeTeam:develop' into develop
02e9089
@sjcsjc123
add gtctl connect mysql://user:password@host:port command
155a9cb
@sjcsjc123
Merge branch 'GreptimeTeam:develop' into develop
95f463a
@sjcsjc123
Implement gtctl cluster connect mysql subcommand GreptimeTeam#3
3c34686
@sjcsjc123
fix bug with golangci-lint GreptimeTeam#3
85da549
@sjcsjc123
improve code style GreptimeTeam#3
b8fe51f
@sjcsjc123
Merge branch 'GreptimeTeam:develop' into develop
418c7b5
@sjcsjc123
feat: add new command gtctl connect pg
ce0dd3f
shawnh2
shawnh2 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@shawnh2 shawnh2 merged commit 3bc7b05 into GreptimeTeam:develop Aug 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnh2 shawnh2 shawnh2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjcsjc123 @shawnh2