BugFix : count() func error when textColor is null #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridho-laksono-lamudi
approved these changes
Dec 16, 2021
Open
bytestream
suggested changes
Aug 5, 2022
| if(is_null($this->textColor)){ | ||
| $this->textColor = array(); | ||
| } | ||
|
|
||
| if (!$this->textColor) { |
There was a problem hiding this comment.
Suggested change
| if (!$this->textColor) { | |
| if ($this->textColor === null || ! $this->textColor) { |
There was a problem hiding this comment.
So when textColor always be an array, why should it compared with null?
The if is for empty arrays i think.
There was a problem hiding this comment.
I see you edit it. !$this->textColor should be enough. If $this->textColor is null its also true.
Comment on lines
+351
to
+355
| // Define a empty array when textColor is null | ||
| if(is_null($this->textColor)){ | ||
| $this->textColor = array(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| // Define a empty array when textColor is null | |
| if(is_null($this->textColor)){ | |
| $this->textColor = array(); | |
| } |
|
I think this PR is obsolet. It is already fixed by a4f7d0f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when count() function receive a null arg happens Warning (in PHP V7+) and Fatal error (in PHP V8+)
with this pull request i tried solve this problem.thanks :)