-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork #103
Comments
@S1SYPHOS Do you plan to create a Symfony Bundle for it? We have issues there and get no response. See Gregwar/CaptchaBundle#231 |
@blankse I didn't plan to, and frankly I don't think I will, since I don't use Symfony myself. I don't know how to properly setup & test such a plugin, and looking at the PRs and issues on the plugin this seems like quite a lot of work .. I'm sorry, but that's something @Gregwar would have to take care of. |
I also forked this to https://github.com/diversen/Captcha |
I did a little more than that 😀 |
Hello, |
@Gregwar I can help in a maintenance capacity if you'd like. |
@Gregwar Sorry for my late reply, but here goes: First of all, I fixed #60, #80, #84, #91 and #100 and applied PRs #74, #89, #92, #95 and #101. While doing so, I refactored a lot of code and added full support for PHP8. Most changes are listed below the first v2 beta release, see here. Later on, I added features like "background noise" (using small random letters), custom fonts and optional support for |
If it is still code compatible with the current version (keeps most of BC, especially the Sf bundle), maybe we could change things here directly, would you agree doing that @S1SYPHOS , if I add you to the owners ? @bytestream are you using the Sf Bundle? Looks like @S1SYPHOS is not using it so maybe we can have another pair of eyes on this matter to keep things compatible 🙂 |
I'm afraid not. We use Laravel and are using this package directly. |
At this point, it's not even close to being compatible 😀 since I'm not using Symfony (never have tbh), I don't know how to test this even if I helped migrate the bundle 😕 |
I see, it drifted too much |
@Gregwar I think at a minimum you can merge the below to cover PHP 8.0 and 8.1 without breaking anything: |
@Gregwar Would be great if you could merge the above, that looks like all that is needed at the moment. |
@Gregwar do you still want some help with maintenance of this library? |
Hello,
I also tagged |
Hey there,
I just released v2 of my fork. I migrated issues & open PRs, added some new features, fixed bugs, added GIF & PNG support, some helper functions & extended its test suite - today I saw your statement in #102 that it's been a long time and I guess you've got many other things on your plate ..
Many thanks for this library,
cheers
S1SYPHOS
The text was updated successfully, but these errors were encountered: