Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork #103

Open
S1SYPHOS opened this issue Apr 4, 2022 · 15 comments
Open

Fork #103

S1SYPHOS opened this issue Apr 4, 2022 · 15 comments

Comments

@S1SYPHOS
Copy link

S1SYPHOS commented Apr 4, 2022

Hey there,
I just released v2 of my fork. I migrated issues & open PRs, added some new features, fixed bugs, added GIF & PNG support, some helper functions & extended its test suite - today I saw your statement in #102 that it's been a long time and I guess you've got many other things on your plate ..

Many thanks for this library,
cheers

S1SYPHOS

@blankse
Copy link

blankse commented Apr 4, 2022

@S1SYPHOS Do you plan to create a Symfony Bundle for it? We have issues there and get no response. See Gregwar/CaptchaBundle#231

@S1SYPHOS
Copy link
Author

S1SYPHOS commented Apr 4, 2022

@blankse I didn't plan to, and frankly I don't think I will, since I don't use Symfony myself. I don't know how to properly setup & test such a plugin, and looking at the PRs and issues on the plugin this seems like quite a lot of work ..

I'm sorry, but that's something @Gregwar would have to take care of.

@diversen
Copy link

diversen commented Jul 25, 2022

I also forked this to https://github.com/diversen/Captcha
It just fixes the issues #100
Which means that it will work on php8.1 (at least in my use-case)

@S1SYPHOS
Copy link
Author

I did a little more than that 😀

@Gregwar
Copy link
Owner

Gregwar commented Jul 27, 2022

Hello,
@S1SYPHOS would you mind reflecting your changes here ?
I am sorry I only have little time to maintain this repository, I am ok with other people taking care 🙂

@bytestream
Copy link

@Gregwar I can help in a maintenance capacity if you'd like.

@S1SYPHOS
Copy link
Author

S1SYPHOS commented Aug 3, 2022

@Gregwar Sorry for my late reply, but here goes:

First of all, I fixed #60, #80, #84, #91 and #100 and applied PRs #74, #89, #92, #95 and #101. While doing so, I refactored a lot of code and added full support for PHP8. Most changes are listed below the first v2 beta release, see here.

Later on, I added features like "background noise" (using small random letters), custom fonts and optional support for tesseract-ocr, hex color support was added as well as docstrings and such, writing virtual files when testing, improved (yet still basic) tests .. and just keeping things as DRY as possible 😁

@Gregwar
Copy link
Owner

Gregwar commented Aug 4, 2022

If it is still code compatible with the current version (keeps most of BC, especially the Sf bundle), maybe we could change things here directly, would you agree doing that @S1SYPHOS , if I add you to the owners ?

@bytestream are you using the Sf Bundle? Looks like @S1SYPHOS is not using it so maybe we can have another pair of eyes on this matter to keep things compatible 🙂

@bytestream
Copy link

@bytestream are you using the Sf Bundle?

I'm afraid not. We use Laravel and are using this package directly.

@S1SYPHOS
Copy link
Author

S1SYPHOS commented Aug 4, 2022

At this point, it's not even close to being compatible 😀 since I'm not using Symfony (never have tbh), I don't know how to test this even if I helped migrate the bundle 😕

@Gregwar
Copy link
Owner

Gregwar commented Aug 5, 2022

I see, it drifted too much
I will try to find a slot to ensure that this is compatible with 8.0 / 8.1 at least (and doesn't break Sf bundle as well)

@bytestream
Copy link

@Gregwar I think at a minimum you can merge the below to cover PHP 8.0 and 8.1 without breaking anything:

  1. Add GitHub workflows #105
  2. Exclude files from composer distribution #106
  3. PHP Deprecated: Implicit conversion from float, CaptchaBuilder.php on… #101
  4. delete invalid break #92

@jshah4517
Copy link

@Gregwar Would be great if you could merge the above, that looks like all that is needed at the moment.

@bytestream
Copy link

@Gregwar do you still want some help with maintenance of this library?

@Gregwar
Copy link
Owner

Gregwar commented Sep 26, 2023

Hello,
I am not sure to understand your bullet points:

  1. and 2) are just workflow/packaging things, how does it prevent PHP from working with PHP8 ?
  2. is merged already, 4) is fixed

I also tagged v1.2.1 to ensure composer re-packaging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@diversen @Gregwar @jshah4517 @blankse @bytestream @S1SYPHOS and others