Apply the same tests to all storage backends #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
approved these changes
Sep 8, 2024
djmitche
added a commit
to djmitche/taskchampion
that referenced
this pull request
Oct 12, 2024
…ctory#453)" This reverts commit c7c2cde.
djmitche
added a commit
that referenced
this pull request
Oct 13, 2024
* Revert "Temporarily make get_task_operations non-public (#464)" This reverts commit 8f3914b. * Revert "Additional tests for Replica methods (#459)" This reverts commit a5f116f. * Revert "Apply the same tests to all storage backends (#453)" This reverts commit c7c2cde. * Revert "Replace `Storage::set_operations` with `sync_complete` and `remove_operation`.` (#451)" This reverts commit d7a7d96. * Revert "Add `get_task_operations` (#450)" This reverts commit 8bfbb9d. * Revert "Add an 'operations.uuid' column, generated and virtual (#449)" This reverts commit 427ad78. * Revert "Add a test for upgrading from 0.7.0 DBs (#448)" This reverts commit fb84873.
djmitche
added a commit
to djmitche/taskchampion
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the storage implementation is becoming more complex as part of #373, let's test that both implementations (and when there are more than two, all implementations) meet the same requirements.