Revert incomplete "expose operations" work #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tFactory#464)" This reverts commit 8f3914b.
This reverts commit a5f116f.
…ctory#453)" This reverts commit c7c2cde.
…emove_operation`.` (GothenburgBitFactory#451)" This reverts commit d7a7d96.
This reverts commit 8bfbb9d.
…nburgBitFactory#449)" This reverts commit 427ad78.
|
I think it's a reasonable course of action. I'll re-land this on a branch and continue working on it, and if that ultimately is rejected, we can pull out those two bits and land them separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts all of the PRs made to support #373 so far, with the intent of trying again after the 0.8.0 release, and when the solution is better understood.