Use NetworkingType instead of EnablePrivateEnvironment in composer provider

[HappyMary16]

The providers implementation use the new networking_type field in Composer API instead of the old enable_private_environment boolean field.

PR do not introduce any change in the user-visible Terraform surface. The enable_private_environment boolean field in Composer Terraform resource remains the only interface for selecting private/public environment in Terraform.

Fixes: hashicorp/terraform-provider-google#26395

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[spapi17]

Could you add release note section in the description with this format?

composer: brief description

Discussed offline: we leave it blank since there's no user facing change.

[zli82016]

@HappyMary16 , can you open a PR only with the api version changes?
Doc: https://googlecloudplatform.github.io/magic-modules/develop/update-dependencies/

Thanks.

[zli82016]

I moved the api version upgrade to a separate PR #16752

[ScottSuarez]

waiting for api upgrade to be merged

[HappyMary16]

PR #16752 with API version upgrade is merged, I merged changed from main to my branch

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 15 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 1 file changed, 15 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 40
Passed tests: 15
Skipped tests: 1
Affected tests: 24

Click here to see the affected service packages

• composer

Action taken

Found 24 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComposerEnvironmentComposer2_private
• TestAccComposerEnvironmentComposer3_basic
• TestAccComposerEnvironmentComposer3_databaseRetention
• TestAccComposerEnvironmentComposer3_update
• TestAccComposerEnvironmentComposer3_updateFromEmpty
• TestAccComposerEnvironmentComposer3_updateToEmpty
• TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork
• TestAccComposerEnvironmentComposer3_updateWithNetworkAttachment
• TestAccComposerEnvironmentComposer3_withNetworkAttachment
• TestAccComposerEnvironment_ComposerV2
• TestAccComposerEnvironment_ComposerV2HighResilience
• TestAccComposerEnvironment_UpdateComposerV2
• TestAccComposerEnvironment_UpdateComposerV2ResilienceMode
• TestAccComposerEnvironment_UpdateComposerV2WithTriggerer
• TestAccComposerEnvironment_composerV2PrivateServiceConnect
• TestAccComposerEnvironment_fixPyPiPackages
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update
• TestAccComposerUserWorkloadsSecret_basic
• TestAccComposerUserWorkloadsSecret_delete
• TestAccComposerUserWorkloadsSecret_update
• TestAccDataSourceComposerUserWorkloadsConfigMap_basic
• TestAccDataSourceComposerUserWorkloadsSecret_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComposerEnvironmentComposer2_private [Debug log]
TestAccComposerEnvironmentComposer3_basic [Debug log]
TestAccComposerEnvironmentComposer3_databaseRetention [Debug log]
TestAccComposerEnvironmentComposer3_update [Debug log]
TestAccComposerEnvironmentComposer3_updateFromEmpty [Debug log]
TestAccComposerEnvironmentComposer3_updateToEmpty [Debug log]
TestAccComposerEnvironmentComposer3_updateWithNetworkAttachment [Debug log]
TestAccComposerEnvironmentComposer3_withNetworkAttachment [Debug log]
TestAccComposerEnvironment_ComposerV2HighResilience [Debug log]
TestAccComposerEnvironment_UpdateComposerV2ResilienceMode [Debug log]
TestAccComposerEnvironment_UpdateComposerV2WithTriggerer [Debug log]
TestAccComposerEnvironment_fixPyPiPackages [Debug log]
TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample [Debug log]
TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete [Debug log]
TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update [Debug log]
TestAccComposerUserWorkloadsSecret_basic [Debug log]
TestAccComposerUserWorkloadsSecret_delete [Debug log]
TestAccComposerUserWorkloadsSecret_update [Debug log]
TestAccDataSourceComposerUserWorkloadsConfigMap_basic [Debug log]
TestAccDataSourceComposerUserWorkloadsSecret_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork [Error message] [Debug log]
TestAccComposerEnvironment_ComposerV2 [Error message] [Debug log]
TestAccComposerEnvironment_UpdateComposerV2 [Error message] [Debug log]
TestAccComposerEnvironment_composerV2PrivateServiceConnect [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[ScottSuarez]

/gcbrun