Changes for adding region parameter for multiregion Point In time res…

[aditikumarii-google]

sql: added `point_in_time_restore_context.region` field to `google_sql_database_instance` resource 

Tracking bug - b/469255829

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 185 insertions(+))
google-beta provider: Diff ( 3 files changed, 185 insertions(+))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• sql

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[zli82016]

google-beta/services/sql/resource_sql_database_instance.go:3431:3: unknown field Region in struct literal of type sqladmin.PointInTimeRestoreContext

[aditikumarii-google]

google-beta/services/sql/resource_sql_database_instance.go:3431:3: unknown field Region in struct literal of type sqladmin.PointInTimeRestoreContext

This is because cl/846845835 marks the region field as GOOGLE_INTERNAL, so the required clients are not generated.
We plan on submitting this PR only when the GOOGLE_INTERNAL tag is removed and the changes in backend are rolled out in prod

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 196 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 196 insertions(+), 4 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• sql

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 191 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 191 insertions(+), 4 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• sql

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[github-actions]

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 180 insertions(+))
google-beta provider: Diff ( 3 files changed, 180 insertions(+))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• sql

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[zli82016]

google-beta/services/sql/resource_sql_database_instance.go:3431:3: unknown field Region in struct literal of type sqladmin.PointInTimeRestoreContext

[aditikumarii-google]

google-beta/services/sql/resource_sql_database_instance.go:3431:3: unknown field Region in struct literal of type sqladmin.PointInTimeRestoreContext

Hi @zli82016
Can you please help me understand why Region field is not getting populated in the PointInTimeRestore struct - https://source.corp.google.com/piper///depot/google3/third_party/golang/google_api/sqladmin/v1beta4/sqladmin-gen.go;rcl=815572610;l=4379
It is added as a proto in cl/846845835
Can you please help generate the client?

[zli82016]

cl/846845835

I checked that Region is not in the latest api https://github.com/googleapis/google-api-go-client/blob/v0.261.0/sqladmin/v1beta4/sqladmin-gen.go#L4519

I guess it will take time for the field Region to be populated into api.

After this field is in the latest api, the api version needs to be updated in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/go.mod#L39

[github-actions]

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 180 insertions(+))
google-beta provider: Diff ( 3 files changed, 180 insertions(+))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• sql

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• sql

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[zli82016]

This PR #16742 to upgrade api version needs being merged first.

[zli82016]

API version upgrading is in
#16752

[zli82016]

@aditikumarii-google , I have merged the PR #16752. Please rebase the main branch.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 180 insertions(+))
google-beta provider: Diff ( 3 files changed, 180 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [point_in_time_restore_context.region]

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 149
Passed tests: 121
Skipped tests: 28
Affected tests: 0

Click here to see the affected service packages

• sql

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 181 insertions(+))
google-beta provider: Diff ( 4 files changed, 181 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [point_in_time_restore_context.region]

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 149
Passed tests: 121
Skipped tests: 28
Affected tests: 0

Click here to see the affected service packages

• sql

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 179 insertions(+))
google-beta provider: Diff ( 4 files changed, 179 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [point_in_time_restore_context.region]

[modular-magician]

Tests analytics

Total tests: 149
Passed tests: 121
Skipped tests: 27
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 181 insertions(+))
google-beta provider: Diff ( 4 files changed, 181 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [point_in_time_restore_context.region]

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 149
Passed tests: 121
Skipped tests: 28
Affected tests: 0

Click here to see the affected service packages

• sql

🟢 All tests passed!

View the build log

[zli82016]

LGTM. Thanks.