Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

see PR I already commented on #5

Open
CedricCabessa opened this issue Jan 23, 2015 · 3 comments
Open

see PR I already commented on #5

CedricCabessa opened this issue Jan 23, 2015 · 3 comments
Labels
enhancement

Comments

@CedricCabessa
Copy link
Contributor

As an user I'd like to have a visual feedback (on web?) to diferentiate PRs I already commented on and my comment is not deprecated
We can use google auth to identify user
@ghost ghost self-assigned this Aug 22, 2015
@ghost
Copy link

ghost commented Aug 22, 2015

I'll do a first simple iteration in which you can optionally pass in your github login as a request parameter.

Google auth can come in a later step :)

@ghost
Copy link

ghost commented Aug 22, 2015

Note that this requires an additional, probably expensive, request for each pull request: the "review comments" request.
Currently we do the "issues comments" request, to scan for 👍 etc. If you want to know about "deprecated" comments, I assume you're referring to review comments, which can be made deprecated when the developer pushes a new commit. We currently don't do this github api call for pull requests.

ghost pushed a commit that referenced this issue Aug 22, 2015
@caarmen
Issue #5: if a login parameter is specified, user-specific info is di…
6a96e94 
…splayed.

For now, just "my open comments" is displayed.
ghost pushed a commit that referenced this issue Aug 22, 2015
@caarmen
Issue #5: if a 'login' parameter is specified, user-specific info is …
84bcbf7 
…displayed.

For now, just "My Open Comments" is displayed. If no 'login'
url parameter is specified, then the "My Open Comments" column is
not displayed.
ghost pushed a commit that referenced this issue Aug 22, 2015
@caarmen
Issue #5: correction for determining which review comments are obsolete.
90fb9ff
ghost pushed a commit that referenced this issue Aug 22, 2015
@caarmen
Issue #5: rename "my_open_comments" to "my_open_comment_count" everyw…
a888865 
…here.
@ghost ghost mentioned this issue Aug 22, 2015
Closed
ghost pushed a commit that referenced this issue Aug 24, 2015
@caarmen
Issue #5: if a 'login' parameter is specified, user-specific info is …
5cfbab0 
…displayed.

For now, just "My Open Comments" is displayed. If no 'login'
url parameter is specified, then the "My Open Comments" column is
not displayed.
ghost pushed a commit that referenced this issue Aug 24, 2015
@caarmen
Issue #5: correction for determining which review comments are obsolete.
134c1d8
ghost pushed a commit that referenced this issue Aug 24, 2015
@caarmen
Issue #5: rename "my_open_comments" to "my_open_comment_count" everyw…
b148e73 
…here.
@ghost ghost mentioned this issue Aug 24, 2015
Merged
CedricCabessa added a commit that referenced this issue Aug 28, 2015
@CedricCabessa
Merge pull request #53 from Genymobile/issue5-my-open-comments-merge-…
10b67b1 
…to-master

Issue #5: if a 'login' parameter is specified, user-specific info is displayed (merge to master)
@CedricCabessa
Copy link
Contributor Author

note sure it still works with the new review system...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CedricCabessa