Issue #5: if a 'login' parameter is specified, user-specific info is displayed. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to improve the visibility on Slack only show the KO keyword is there is an actual KO on the PR. Do not show the KO count because one is enough to block the PR.
Only show KO on Slack if relevant
…displayed. For now, just "My Open Comments" is displayed. If no 'login' url parameter is specified, then the "My Open Comments" column is not displayed.
| @@ -123,6 +123,9 @@ | |||
|
|
|||
| ROOT_URLCONF = 'gm_pr.urls' | |||
|
|
|||
| from django.conf.global_settings import TEMPLATE_CONTEXT_PROCESSORS | |||
| TEMPLATE_CONTEXT_PROCESSORS += ("django.core.context_processors.request",) | |||
There was a problem hiding this comment.
info: This change allows us to access {{request.GET}} from the template html files.
|
Screenshot: the "My Open Comments" column is just before the LGTM column: |
CedricCabessa
force-pushed
the
hackathon
branch
from
5267193
to
d486bf1
Compare
This was referenced Aug 24, 2015
Closed
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, just "My Open Comments" is displayed. If no 'login'
url parameter is specified, then the "My Open Comments" column is
not displayed.
Note, as the issue #5 mentions, this is a simple first iteration, where the user id is provided in the request query arguments.