Skip to content

Commit

Permalink
Issue #5: correction for determining which review comments are obsolete.
Browse files Browse the repository at this point in the history
  • Loading branch information
caarmen committed Aug 22, 2015
1 parent 84bcbf7 commit 90fb9ff
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gm_pr/prfetcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ def get_open_comment_count(url, user):
open_comments=0
review_comments = paginablejson.PaginableJson(url)
for review_comment in review_comments:
# In obsolote comments, the commit_id != original_commit_id.
if review_comment['commit_id'] == review_comment['original_commit_id'] and review_comment['user']['login'] == user:
# In obsolote comments, the position is None
if review_comment['position'] is not None and review_comment['user']['login'] == user:
open_comments +=1
return open_comments

Expand Down

0 comments on commit 90fb9ff

Please sign in to comment.