beignet.root_scalar #26
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x00b1
reviewed
May 29, 2024
|
Questions we should answer before merging:
|
Comparing with scipy maybe this should be renamed to |
kleinhenz
commented
Jun 11, 2024
| x0 = torch.zeros([0]) | ||
|
|
||
| for iteration in range(maxiter): | ||
| b = x0 - torch.linalg.solve(torch.func.jacfwd(func)(x0), func(x0)) |
There was a problem hiding this comment.
another reason to separate root and root_scalar would be to have an implementation that avoids doing a full linear solve for arrays of scalar problems where the jacobian is diagonal.
kleinhenz
had a problem deploying
to
test.pypi.org
GitHub Actions
Failure
kleinhenz
temporarily deployed
to
test.pypi.org
GitHub Actions
Inactive
kleinhenz
commented
Aug 12, 2024
| output = () | ||
|
|
||
| for g, b2 in zip(grad_outputs, b, strict=True): | ||
| output = (*output, -g * b2 / a) |
There was a problem hiding this comment.
why is this style preferred? I don't think the original expression with the generator introduces any mutation right?
kleinhenz
temporarily deployed
to
test.pypi.org
GitHub Actions
Inactive
kleinhenz
temporarily deployed
to
test.pypi.org
GitHub Actions
Inactive
kleinhenz
temporarily deployed
to
test.pypi.org
GitHub Actions
Inactive
kleinhenz
temporarily deployed
to
test.pypi.org
GitHub Actions
Inactive
kleinhenz
temporarily deployed
to
test.pypi.org
GitHub Actions
Inactive
kleinhenz
temporarily deployed
to
test.pypi.org
GitHub Actions
Inactive
kleinhenz
temporarily deployed
to
test.pypi.org
GitHub Actions
Inactive
kleinhenz
temporarily deployed
to
test.pypi.org
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.