<WIP> Removing SAC and Dissemination.

.github/workflows/cypress-testing-from-container.yml

@@ -27,8 +27,8 @@ jobs:
       CYPRESS_API_GOV_KEY_ADMIN: ${{ secrets.CYPRESS_API_GOV_KEY_ADMIN }}
       CYPRESS_API_GOV_USER_ID_ADMIN: ${{ secrets.CYPRESS_API_GOV_USER_ID_ADMIN }}
       CYPRESS_API_GOV_JWT: ${{ secrets.CYPRESS_API_GOV_JWT }}
-      CYPRESS_API_VERSION: "api_v1_1_0"
-      CYPRESS_ADMIN_API_VERSION: "admin_api_v1_1_0"
+      CYPRESS_API_VERSION: "api_v1_2_0"
+      CYPRESS_ADMIN_API_VERSION: "admin_api_v1_2_0"
       CYPRESS_BASE_URL: "http://localhost:8000"
       CYPRESS_LOGIN_TEST_EMAIL: ${{ secrets.CYPRESS_LOGIN_TEST_EMAIL }}
       CYPRESS_LOGIN_TEST_PASSWORD: ${{ secrets.CYPRESS_LOGIN_TEST_PASSWORD }}
@@ -65,10 +65,6 @@ jobs:
         working-directory: ./backend
         run: docker compose run web python manage.py load_fixtures
 
-      - name: Create materialized view
-        working-directory: ./backend
-        run: docker compose run web python manage.py materialized_views --create
-
       - uses: browser-actions/setup-chrome@v1
         with:
           install-chromedriver: true

.github/workflows/regression-tests.yml

@@ -32,8 +32,8 @@ jobs:
       CYPRESS_API_GOV_KEY_ADMIN: ${{ secrets.CYPRESS_API_GOV_KEY_ADMIN }}
       CYPRESS_API_GOV_USER_ID_ADMIN: ${{ secrets.CYPRESS_API_GOV_USER_ID_ADMIN }}
       CYPRESS_API_GOV_URL: ${{ secrets.CYPRESS_API_GOV_URL }}
-      CYPRESS_API_VERSION: "api_v1_1_0"
-      CYPRESS_ADMIN_API_VERSION: "admin_api_v1_1_0"
+      CYPRESS_API_VERSION: "api_v1_2_0"
+      CYPRESS_ADMIN_API_VERSION: "admin_api_v1_2_0"
       CYPRESS_BASE_URL: ${{ inputs.url }}
       CYPRESS_LOGIN_TEST_EMAIL: ${{ secrets.CYPRESS_LOGIN_TEST_EMAIL }}
       CYPRESS_LOGIN_TEST_PASSWORD: ${{ secrets.CYPRESS_LOGIN_TEST_PASSWORD }}

.github/workflows/testing-from-build.yml

@@ -103,10 +103,6 @@ jobs:
         working-directory: ./backend
         run: docker compose run web python manage.py load_fixtures
 
-      - name: Create materialized view
-        working-directory: ./backend
-        run: docker compose run web python manage.py materialized_views --create
-
       - name: Run A11y tests
         uses: cypress-io/github-action@v6
         with:

.github/workflows/testing-from-ghcr.yml

@@ -105,10 +105,6 @@ jobs:
         working-directory: ./backend
         run: docker compose run web python manage.py load_fixtures
 
-      - name: Create materialized view
-        working-directory: ./backend
-        run: docker compose run web python manage.py materialized_views --create
-
       - name: Run A11y tests
         uses: cypress-io/github-action@v6
         with:

backend/.profile

@@ -13,7 +13,6 @@ source tools/api_teardown.sh
 source tools/migrate_app_tables.sh
 source tools/api_standup.sh
 source tools/run_collectstatic.sh
-source tools/materialized_views.sh
 source tools/create_staffusers.sh
 
 #####
@@ -47,8 +46,6 @@ if [[ "$CF_INSTANCE_INDEX" == 0 ]]; then
     # run_collectstatic
     # gonogo "run_collectstatic"
 
-    # materialized_views
-    # gonogo "materialized_views"
 
     #####
     # CREATE STAFF USERS

backend/api/serializers/__init__.py

@@ -4,7 +4,7 @@
     AccessSerializer,
     CERTIFIERS_HAVE_DIFFERENT_EMAILS,
 )
-from api.serializers.audit import AuditSerializer, SingleAuditChecklistSerializer
+from api.serializers.audit import AuditSerializer
 from api.serializers.auditee import AuditeeInfoSerializer
 from api.serializers.eligibility import EligibilitySerializer
 from api.serializers.uei import UEISerializer
@@ -16,7 +16,6 @@
     AuditeeInfoSerializer,
     AuditSerializer,
     EligibilitySerializer,
-    SingleAuditChecklistSerializer,
     UEISerializer,
 ]
 

backend/api/serializers/access.py

@@ -109,44 +109,25 @@ class AccessListSerializer(serializers.ModelSerializer):
     report_id = serializers.SerializerMethodField()
     submission_status = serializers.SerializerMethodField()
 
-    # TODO: Update Post SOC Launch
     @staticmethod
     def get_auditee_uei(access):
-        return (
-            access.audit.audit.get("general_information", {}).get("auditee_uei", None)
-            if access.audit
-            else access.sac.auditee_uei
-        )
+        return access.audit.auditee_uei
 
     @staticmethod
     def get_auditee_fiscal_period_end(access):
-        return (
-            access.audit.audit.get("general_information", {}).get(
-                "auditee_fiscal_period_end", None
-            )
-            if access.audit
-            else access.sac.auditee_fiscal_period_end
-        )
+        return access.audit.auditee_fiscal_period_end
 
     @staticmethod
     def get_auditee_name(access):
-        return (
-            access.audit.audit.get("general_information", {}).get("auditee_name", None)
-            if access.audit
-            else access.sac.auditee_name
-        )
+        return access.audit.auditee_name
 
     @staticmethod
     def get_report_id(access):
-        return access.audit.report_id if access.audit else access.sac.report_id
+        return access.audit.report_id
 
     @staticmethod
     def get_submission_status(access):
-        return (
-            access.audit.submission_status
-            if access.audit
-            else access.sac.submission_status
-        )
+        return access.audit.submission_status
 
     class Meta:
         model = Access

backend/api/serializers/audit.py

@@ -1,13 +1,6 @@
 from rest_framework import serializers
 
-from audit.models import SingleAuditChecklist, Audit
-
-
-# TODO: Update Post SOC Launch -> Delete
-class SingleAuditChecklistSerializer(serializers.ModelSerializer):
-    class Meta:
-        model = SingleAuditChecklist
-        fields = "__all__"
+from audit.models import Audit
 
 
 class AuditSerializer(serializers.ModelSerializer):

backend/api/test_serializers.py

@@ -2,6 +2,8 @@
 from unittest import TestCase
 
 from unittest.mock import patch
+
+from django.contrib.auth.models import User
 from django.utils import timezone as django_timezone
 from datetime import timedelta
 from django.test import SimpleTestCase
@@ -17,7 +19,8 @@
     AccessAndSubmissionSerializer,
     CERTIFIERS_HAVE_DIFFERENT_EMAILS,
 )
-from audit.models import User, Access, UeiValidationWaiver
+from audit.models import Access, UeiValidationWaiver, Audit
+from audit.models.constants import STATUS
 
 
 class EligibilityStepTests(SimpleTestCase):
@@ -570,20 +573,27 @@ def test_certifiers_same_email(self):
 
 class AccessListSerializerTests(TestCase):
     def test_expected_fields_included(self):
-        access = baker.make(Access)
+        audit_data = {
+            "general_information": {
+                "auditee_uei": "TEST_UEI",
+                "auditee_fiscal_period_end": "2024-12-31",
+                "auditee_name": "Steve",
+            }
+        }
+
+        audit = baker.make(
+            Audit, version=0, audit=audit_data, submission_status=STATUS.IN_PROGRESS
+        )
+        access = baker.make(Access, audit=audit)
 
         serializer = AccessListSerializer(access)
 
-        # TODO: Update Post SOC Launch
-        # remove if/else when we deprecate SAC data.
         self.assertEqual(
             serializer.data["auditee_uei"],
             (
                 access.audit.audit.get("general_information", {}).get(
                     "auditee_uei", None
                 )
-                if access.audit
-                else access.sac.auditee_uei
             ),
         )
         self.assertEqual(
@@ -592,8 +602,6 @@ def test_expected_fields_included(self):
                 access.audit.audit.get("general_information", {}).get(
                     "auditee_fiscal_period_end", None
                 )
-                if access.audit
-                else access.sac.auditee_fiscal_period_end
             ),
         )
         self.assertEqual(
@@ -602,20 +610,11 @@ def test_expected_fields_included(self):
                 access.audit.audit.get("general_information", {}).get(
                     "auditee_name", None
                 )
-                if access.audit
-                else access.sac.auditee_name
             ),
         )
-        self.assertEqual(
-            serializer.data["report_id"],
-            access.audit.report_id if access.audit else access.sac.report_id,
-        )
+        self.assertEqual(serializer.data["report_id"], access.audit.report_id)
         self.assertEqual(
             serializer.data["submission_status"],
-            (
-                access.audit.submission_status
-                if access.audit
-                else access.sac.submission_status
-            ),
+            (access.audit.submission_status),
         )
         self.assertEqual(serializer.data["role"], access.role)

backend/api/test_uei.py

@@ -635,7 +635,6 @@ def test_automatic_waiver_issuance_for_sam_gov(self):
                 before = UeiValidationWaiver.objects.all().count()
                 results = get_uei_info_from_sam_gov(uei=test_uei)
                 after = UeiValidationWaiver.objects.all().count()
-                print(f"{before} {after}")
                 self.assertTrue(after - before == 1)
                 self.assertTrue(results["valid"])
                 self.assertEqual(