<WIP> Removing SAC and Dissemination. #4890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not needed in light of the `source-of-truth/events` PR. (https://github.com/GSA-TTS/FAC/pull/4784/files)
- Address feedback where we no longer need`_convert_additional_fields()` - it is a duplicate of a method in `utils.py`. - Minor cleanup on `_populate_accesses()`. I no longer felt it needed to be an isolated function while addressing the above bullet point
- Supplied two new arguments, "--disseminated" and "--intake". The first will only fetch SAC data that is disseminated, while the second will only fetch SAC data that has not yet disseminated. - Rather than iterate through 50k SACs at a time, this change introduces a while condition that will continuously migrate batches of 100 until all relevant SACs are migrated. This should mean we only need to run the command once at a time.
Bandit does not like potential SQL injection with string-based query construction, however this logic is only accessed internally.
- Added `migrated_to_audit` flag on `SingleAuditChecklist` for determining which SACs have not yet been migrated. - Added some logic (for local testing ONLY) which cleans up audit data and references to mimic a clean slate.
- Updated `generate_audit_indexes` to catch an issue where `auditee_fiscal_period_end` is an empty string for some records. - `migrate_audits` command now uses ORM instead of raw queries for performance improvements. - Improved logging of `migrate_audits` for better monitoring of progress. - Inserted `null=True` into `migrated_to_audit` booleanfield for SACs. - Setting `migrated_to_audit=True` for SACs that get created during intake process. This is because an Audit already gets created with the SAC during this step.
- `0019_audit_auditee_name` and `0019_singleauditchecklist_migrated_to_audit` were migration files that overlapped because they were created from separate branches. - This change moves `migrated_to_audit` sequentially after `audit_auditee_name`. This should be the extent of the changes needed to correct the issue, as the migration files do not conflict with one another.
Currently this is only generating SubmissionEvents. We want the History table to replicate these.
This is not needed in light of the `source-of-truth/events` PR. (https://github.com/GSA-TTS/FAC/pull/4784/files)
* Add Audit Management Endpoints * Add unlock after certification to monitoring * Adjust row/column count for management endpoints * Mispelling is a crime punished with loading times * UNCLEAR COMMAS * Resolve copy paste error in a monitoring query. * Monitor even even more endpoints Add submission elibility (steps 1-3) and information form endpoints
* Initial Legacy Provider Update Sets the new provider into the terraform providers.tf and runs a dual provider setup, forcing any resource that does not natively interact with the new provider using: provider = cloudfoundry-community * ClamAV version 2.0.0 - Removes app_name_or_id for network policies - Reintroduces external network policy for clamav -> proxy - Deployed successfully around 9a with v2.0.0 clamav module and was able to successfully validate a file at around 916a without any issues * Clamav Module Update * Preliminary setup for v2.1.0 upgrade * Upgrade resources * Add upgrade docs * Add app -> clamav network policy * Update gitignore * Update gitignore * Update prepare-proxy.sh * Meta Provider Update * Update managed providers * prevent globbing * Move sandbox imports * Live commands * Documentation on all commands * Meta Module Upgrade * Dev and Preview Module Upgrade * Add routes.tf * Staging Module Upgrade * Production Module Upgrade * Update prod instances * Update bootstrap provider version * Update sandbox provider version * Upgrade sandbox shared modules provider
[SOT2] Remove Sling ARM64 requirement
Minimum allowed line rate is |
Real-time audit validations in SOTv2
|
This pull request is not up to date with main. Please merge main into this brach or rebase this branch onto main. This PR should not be approved until all status checks pass. If you see this message, please rerun all status checks before merging. |
This data would be redundant... and thereby wasteful because audit.audit can be massive in size.
|
Closed after harmonization efforts between internal representations and performance work on external representations completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised, I pushed this branch.
This is a lot of work in progress. Most tests are still failing. We need to work together to fix:
Luckily fixing Unit Test issues, usually fixes linting issues at the same time.
We can sync in the next stand about who is working on what.