Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Improvements to the save data system to prevent overwriting when resolution fails. #3728

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

EliteMasterEric
Copy link
Member

@EliteMasterEric EliteMasterEric commented Oct 18, 2024

Does this PR close any issues? If so, link them below.

#3679

Briefly describe the issue(s) fixed.

  • Replaced all Enum fields with Enum Abstract fields.
  • Incremented the Save data version to 2.1.0 (since this is a breaking change) and implemented migration.
    • Older versions of the game will now complain that the save data is too new when trying to load.
    • Had to create some dummy enums in the save data migrator to prevent errors from loading older saves.
  • In the event that the save data fails to parse, the game will now display a big warning popup telling the user to report the issue. It will then create a new save, leaving the broken save in place.

Include any relevant screenshots or videos.

image

@github-actions github-actions bot added haxe Issue/PR modifies game code documentation Issue/PR modifies documentation or README files large A large pull request with more than 100 changes labels Oct 18, 2024
@EliteMasterEric EliteMasterEric added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression status: reviewing internally This PR is under internal review and quality assurance testing labels Oct 18, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.3 milestone Oct 18, 2024
@EliteMasterEric EliteMasterEric changed the base branch from main to develop October 18, 2024 21:35
@ninjamuffin99 ninjamuffin99 merged commit 5819a43 into develop Oct 18, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue/PR modifies documentation or README files haxe Issue/PR modifies game code large A large pull request with more than 100 changes status: reviewing internally This PR is under internal review and quality assurance testing type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants