[BUGFIX] Fix the Save File being overriden in certain occassions, such as downgrading to versions between 0.5.2 and 0.3.0 #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: The previous Enums DON'T get saved as Enums due to the Serializer Bug. Instead they get saved as Abstract Enums. The previous Enums were made deprecated as a form of backwards compatibility, however due to the Serializer Bug it is impossible to save current Enum Abstracts and previous Enums, and thus they are the only fields that get reset. To prevent this, a change to haxe's Serializer would have to be made.
github-actions
bot
added
large
|
Emergency save file hotfix yes please! |
|
These particular changes do not resolve the problem as mentioned in #3679. Replacing enums with enum abstracts without proper workarounds will actually exacerbate the issue, and there is no case in which Closed in favor of #3728. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
3679
Briefly describe the issue(s) fixed.
Modifies the Save File so that it uses Enum Abstracts instead of Enum fields. Also adds a proper backup system, in case of something going horrible.
Include any relevant screenshots or videos.
2024-10-18.22-49-08.mp4
Note
Considering Enum fields are bugged, they are the only ones that get reset when changing from the current version to a version in the title. A fix to this would require a fix to haxe's Serializer classes, which is unlikely to happen (both flixel uses openfl to store things and openfl uses haxe's Serializer classes to store the data).
But also like who the hell would play on an older version after 0.3.0 like I get for previous versions but why this range lol