-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Re-add out of date screen #2720
base: develop
Are you sure you want to change the base?
Conversation
This implementation of versioning may not fit the devs standards. It's just comparing a string. May be best to look after with thx's semantic versioning library, to differentiate between versions. Still a good thing to add back! |
Could you exclude the |
NOTE: This pull request is similar to #2633. |
Yeah I can try to, thanks for commenting! Hopefully after I make the changes it will be well enough to merge! |
@Ethan-makes-music Did you ever get around to this? I don't see any changes. It'd be nice if you could also resolve the existing merge conflicts. |
This works on all platforms from my knowledge!
I re added the out of date screen referenced in #2496 and it may be pretty janky (sorry about that).
The way you can tell it the newest version is by changing the gitVersion.txt to the newest version. And it will show the screen once you press enter in the Title state if the versions do not match
Also did more code clean up in this PR!
I'm probably missing a few instructions but a simple look through the code should kinda explain it.
If this PR ends up getting merged, you need to change the path of the gitVersion.txt to the one in the actual funkin repo instead of it being the path to my fork!
I have only been coding in haxe for a year so apologies :)
(I had to open a new PR because I was stupid and discarded all 14 commits of the first PR so sorry)
OLD PR: #2631