Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Re-add out of date screen #2720

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Ethan-makes-music
Copy link
Contributor

This works on all platforms from my knowledge!

I re added the out of date screen referenced in #2496 and it may be pretty janky (sorry about that).
The way you can tell it the newest version is by changing the gitVersion.txt to the newest version. And it will show the screen once you press enter in the Title state if the versions do not match

Also did more code clean up in this PR!

I'm probably missing a few instructions but a simple look through the code should kinda explain it.

If this PR ends up getting merged, you need to change the path of the gitVersion.txt to the one in the actual funkin repo instead of it being the path to my fork!

I have only been coding in haxe for a year so apologies :)

(I had to open a new PR because I was stupid and discarded all 14 commits of the first PR so sorry)

OLD PR: #2631

@tposejank
Copy link
Contributor

tposejank commented Jun 9, 2024

This implementation of versioning may not fit the devs standards. It's just comparing a string. May be best to look after with thx's semantic versioning library, to differentiate between versions.

Still a good thing to add back!

@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature. status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage The bug or PR has not been reviewed yet. labels Jun 17, 2024
@EliteMasterEric
Copy link
Member

Could you exclude the v in the gitVersion file, then perform comparison using funkin.util.VersionUtil? That way, you can check if there is a minor version difference (which indicates new songs or major features) or a patch version difference (which indicates new bug fixes or minor features).

@EliteMasterEric
Copy link
Member

NOTE: This pull request is similar to #2633.

@Ethan-makes-music
Copy link
Contributor Author

Could you exclude the v in the gitVersion file, then perform comparison using funkin.util.VersionUtil? That way, you can check if there is a minor version difference (which indicates new songs or major features) or a patch version difference (which indicates new bug fixes or minor features).

Yeah I can try to, thanks for commenting! Hopefully after I make the changes it will be well enough to merge!

@EliteMasterEric EliteMasterEric added the large A large pull request with more than 100 changes label Jul 11, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric
Copy link
Member

EliteMasterEric commented Sep 23, 2024

@Ethan-makes-music Did you ever get around to this? I don't see any changes.

It'd be nice if you could also resolve the existing merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large A large pull request with more than 100 changes status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants