Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add OutdatedSubState #2633

Closed
wants to merge 8 commits into from
Closed

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented May 30, 2024

i've noticed that there exists an OutdatedSubState which is never used, so i thought about implementing it.
it checks the project.xml version of the current build and compares it to the project.xml version from the main branch.
this check is only done for desktop versions.

we could also use the latest commit hash from the main branch to compare against, but that be more annoying, so i didnt do the check that way.

(i have noticed that #2631 already implemented the OutdatedSubState, however i dont like that implementation, so im gonna keep this open)

@lemz1 lemz1 changed the title [FEATURE] Add OutdatedState [FEATURE] Add OutdatedSubState May 30, 2024
@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jun 17, 2024
@EliteMasterEric
Copy link
Member

As much as I generally like this implementation's use of XML parsing, I have an internal PR which removes the XML entirely in favor of another system which uses Haxe code instead.

The version check file should definitely be a separate file. The code should also definitely use the semantic version checking systems found in funkin.util.VersionUtil.

@EliteMasterEric EliteMasterEric added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Jun 17, 2024
@EliteMasterEric
Copy link
Member

NOTE: This pull request is similar to #2720.

@lemz1
Copy link
Contributor Author

lemz1 commented Jun 17, 2024

As much as I generally like this implementation's use of XML parsing, I have an internal PR which removes the XML entirely in favor of another system which uses Haxe code instead.

The version check file should definitely be a separate file. The code should also definitely use the semantic version checking systems found in funkin.util.VersionUtil.

im gonna close this for the time being, since it makes more sense to me to wait for the new version system to be fully implemented

@lemz1 lemz1 closed this Jun 17, 2024
@Hundrec Hundrec removed the status: needs revision Cannot be approved because it is awaiting some work by the contributor. label Jan 22, 2025
@AbnormalPoof AbnormalPoof added the status: rejected Issue did not pass review or PR cannot be approved. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants