Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused local variable and fixed wrong type of the parameter #118

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Unused local variable and fixed wrong type of the parameter #118

merged 2 commits into from
Feb 9, 2024

Conversation

miamibc
Copy link

@miamibc miamibc commented Feb 5, 2024

Constant problem of projects with Symfony1 - wrong type string in phpdoc block for function Collection::fromArray() must be array

connorhu
connorhu approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@connorhu connorhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the two different modifications in separate commits, but the fix is fine! Thanks for the PR.

@connorhu connorhu mentioned this pull request Feb 5, 2024
Open
thePanz
thePanz requested changes Feb 8, 2024
View reviewed changes
Copy link
Member

@thePanz thePanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please:

  1. Split the code change in two different commits
  2. Rebase on latest master branch

Then it can be merged

@miamibc
Copy link
Author

miamibc commented Feb 9, 2024

You made me a quest from very very very dumb fix.
Is it really necessary to split this into two commits?

@thePanz
Copy link
Member

thePanz commented Feb 9, 2024 •
edited
Loading

You made me a quest from very very very dumb fix. Is it really necessary to split this into two commits?

I feel like a clean way to proceed.
I can prepared those two changes myself and set you as author.

Thanks for opening the PR!

@thePanz thePanz self-requested a review February 9, 2024 10:04
@thePanz thePanz merged commit ff63f6c into FriendsOfSymfony1:master Feb 9, 2024
5 checks passed
@miamibc
Copy link
Author

miamibc commented Feb 9, 2024

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorhu connorhu connorhu approved these changes

@thePanz thePanz thePanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miamibc @thePanz @connorhu