Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused private properties and unused local variables #119

Open
connorhu opened this issue Feb 5, 2024 · 2 comments
Open

unused private properties and unused local variables #119

connorhu opened this issue Feb 5, 2024 · 2 comments

Comments

@connorhu
Copy link
Collaborator

connorhu commented Feb 5, 2024

Because of #118, it came up that I should check how many unused local variables (166) and unused private properties (8) there are. What do you think, is the test coverage complete enough to remove these variables?
@thePanz
Copy link
Member

thePanz commented Feb 5, 2024

can phpstan identify those unused private properties?

@connorhu
Copy link
Collaborator Author

connorhu commented Feb 5, 2024 •
edited
Loading

UnusedVariableRule can do this, i guess.

@connorhu connorhu mentioned this issue Feb 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thePanz @connorhu