tgl: Fix PD controller version #51
Merged
+67
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On TGL we modified the base version, not the app version.
`-version` would show the incorrect version.
`--pd-info` shows both.
```
FS1:\> framework_tool.efi --versions
UEFI BIOS
Version: 03.19
Release Date: 05/29/2023
EC Firmware
Build version: "hx20_v0.0.1-f6d6b92 2023-05-26 00:03:59 runner@fv-az504-734"
RO Version: "hx20_v0.0.1-f6d6b92"
RW Version: "hx20_v0.0.1-f6d6b92"
Current image: RO
PD Controllers
Right (01)
Main: 3.4.0.2575 (Active)
Backup: 3.4.0.2575
Left (23)
Main: 3.4.0.2575 (Active)
Backup: 3.4.0.2575
Retimers
Left: 0xCF (207)
Right: 0xCF (207)
```
Signed-off-by: Daniel Schaefer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On TGL we modified the base version, not the app version.
-versionwould show the incorrect version.--pd-infoshows both.