Create version check function - #32
Merged
Merged
Conversation
Member
|
If you run Currently the compare command uses the first one. But that's a bit verbose. How about the check just the |
JohnAZoidberg
force-pushed
the
version_check
branch
from
August 7, 2024 07:58
43d80e4 to
7ea4ab0
Compare
Member
|
I rebased onto #51, rebased conflicts and force-pushed. |
Member
|
I fixed it for TGL, didn't try it on TGL or in UEFI shell yet. |
Member
|
@kiram9 I implemented AC side checking like this. |
JohnAZoidberg
force-pushed
the
version_check
branch
from
August 9, 2024 02:37
bafc284 to
fb920e6
Compare
This will check if versions match and return 0 if match or 1 if not match. This can run in UEFI shell etc. Signed-off-by: Kieran Levin <ktl@frame.work>
Make sure it's the active one, and use base version on TGL. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
version_check
branch
from
October 21, 2024 05:54
fb920e6 to
33e8db8
Compare
JohnAZoidberg
approved these changes
Oct 21, 2024
JohnAZoidberg
left a comment
Member
There was a problem hiding this comment.
A bit messy but let's get it in now, so we don't have to deal with more conflicts later.
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
version_check
branch
from
October 21, 2024 05:58
33e8db8 to
69c97b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will check if versions match and return 0 if match or 1 if not match.
This can run in UEFI shell etc.