Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed type of FhirEvalContext.TerminologyService #2909

Merged
merged 5 commits into from
Oct 22, 2024
Merged

changed type of FhirEvalContext.TerminologyService #2909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93ed01d
changed type
Kasdejong Oct 10, 2024
4147ab2
Merge branch 'develop-6.0' into feature/change-terminology-service-type
Kasdejong Oct 17, 2024
d2e2857
updated CompatibilitySuppressions.xml
Kasdejong Oct 17, 2024
44910df
Merge branch 'develop-6.0' into feature/change-terminology-service-type
Kasdejong Oct 22, 2024
4bc96f9
Merge branch 'develop-6.0' into feature/change-terminology-service-type
ewoutkramer Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,4 +357,18 @@
<Right>lib/netstandard2.0/Hl7.Fhir.Base.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Hl7.Fhir.FhirPath.FhirEvaluationContext.get_TerminologyService</Target>
<Left>lib/net8.0/Hl7.Fhir.Base.dll</Left>
<Right>lib/net8.0/Hl7.Fhir.Base.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Hl7.Fhir.FhirPath.FhirEvaluationContext.get_TerminologyService</Target>
<Left>lib/netstandard2.0/Hl7.Fhir.Base.dll</Left>
<Right>lib/netstandard2.0/Hl7.Fhir.Base.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
</Suppressions>
2 changes: 1 addition & 1 deletion src/Hl7.Fhir.Base/FhirPath/FhirEvaluationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public FhirEvaluationContext(ScopedNode node)
/// </summary>
public static new FhirEvaluationContext WithResourceOverrides(ITypedElement? resource, ITypedElement? rootResource = null) =>
(FhirEvaluationContext)EvaluationContext.WithResourceOverrides(resource, rootResource);
public ITerminologyService? TerminologyService { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this hurt us when trying to implement the other terminology-related fhirpath functions except member-of?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion in #2590. I am not sure, just doing what I'm told :)

public ICodeValidationTerminologyService? TerminologyService { get; set; }

private static ITypedElement toNearestResource(ScopedNode node)
{
Expand Down