changed type of FhirEvalContext.TerminologyService #2909
Conversation
Kasdejong
added
the
breaking change
| @@ -69,7 +69,7 @@ public FhirEvaluationContext(ScopedNode node) | |||
| /// </summary> | |||
| public static new FhirEvaluationContext WithResourceOverrides(ITypedElement? resource, ITypedElement? rootResource = null) => | |||
| (FhirEvaluationContext)EvaluationContext.WithResourceOverrides(resource, rootResource); | |||
| public ITerminologyService? TerminologyService { get; set; } | |||
There was a problem hiding this comment.
Wouldn't this hurt us when trying to implement the other terminology-related fhirpath functions except member-of?
There was a problem hiding this comment.
See discussion in #2590. I am not sure, just doing what I'm told :)
|
Haha. See, I had the same argument last year. |
|
Yeah, and I think you are right. We should probably pick an interface that has memberOf() as well. Of course, it's just a matter of time before people want more, though. But that does not mean all termservices also implement it. That's the beauty of making it explicit. |
|
Would it make sense to add a way for the ITerminologyService to report which methods are supported by the service? |
|
Both ValueSetValidateCode (memberOf) and Subsumes are defined in ICodeValidationTerminologyService. It is just operations like Closure and Expand which are not in this interface. |
# Conflicts: # src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
Description
Changed the type of FhirEvaluationContext.TerminologyService to ICodeValidationTerminologyService
Related issues
Closes #2590