-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember last opened chat tab #3205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a high level this makes sense.
I just wonder if we could just use a map or something in Chat navigation instead of a list of a new class.
When creating the |
Fair I suppose. Although the last visible message is stored in the Chat channel object now just as FYI |
@@ -14,7 +14,7 @@ | |||
<children> | |||
<TabPane fx:id="tabPane" tabClosingPolicy="ALL_TABS" AnchorPane.bottomAnchor="0.0" AnchorPane.leftAnchor="0.0" | |||
AnchorPane.rightAnchor="0.0" AnchorPane.topAnchor="0.0" visible="false"> | |||
<Tab text="+" closable="false"> | |||
<Tab fx:id="addChannelTab" text="+" closable="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fx:id value actually gets set as the id for the node. So you shouldn't need to set the id in the controller itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! I'll know, thanks. But we don't need the id anymore. Found a more elegant solution using isClosable
condition
8f65a84
to
d232b96
Compare
d232b96
to
70df5e4
Compare
Since the main tabs are now recreated with each click, the last opened chat tab of the channel or player is no longer remembered.
This pull request will help bring this feature back.